New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump CoreDNS to GA in kubeadm #63401
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rajansandeep Assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @luxas
@@ -54,7 +54,7 @@ var InitFeatureGates = FeatureList{ | |||
StoreCertsInSecrets: {FeatureSpec: utilfeature.FeatureSpec{Default: false, PreRelease: utilfeature.Alpha}}, | |||
// We don't want to advertise this feature gate exists in v1.9 to avoid confusion as it is not yet working | |||
HighAvailability: {FeatureSpec: utilfeature.FeatureSpec{Default: false, PreRelease: utilfeature.Alpha}, MinimumVersion: v190, HiddenInHelpText: true}, | |||
CoreDNS: {FeatureSpec: utilfeature.FeatureSpec{Default: false, PreRelease: utilfeature.Beta}, MinimumVersion: v190}, | |||
CoreDNS: {FeatureSpec: utilfeature.FeatureSpec{Default: false, PreRelease: utilfeature.GA}, MinimumVersion: v190}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
default - true please .
I also cherry-picked this into my PR for defaulting the CoreDNS feature flag to true: #63509 |
@timothysc @detiber @luxas : after talk with @thockin, @bowei - it was agreed that CoreDNS will go GA this version 1.11 of k8s, but will be the default DNS service only after some adoption by users - which means at earlieast v1.12 So, the KEP was changed to include only the GA part : kubernetes/community#1956 Another KEP has to ne opened for the "Default" part. and the initial feature description was also changes, and now there are 2 features proposed opened:
|
can be closed given it was cherry picked here #63509. |
@fturib We're enabling it by default in v1.11 anyway. That way we'll also be kind of a guinea pig (although that really shouldn't be the case for GA) and maybe catch potential issues before v1.12. It's probably better than the current kube-dns anyway. |
Closing in favor of #63509. Thanks! |
What this PR does / why we need it:
Graduates CoreDNS to GA.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: