Make AWS configuration file optional (fall-back to metadata service)

[justinsb]

The AWS configuration file currently only has the current AZ. It is easy to get that from the metadata service.

This brings AWS closer to GCE, and also avoids the need to create an aws.conf file for kubelet on the minions when we do EBS volumes.

[bprashanth]

@mbforbes based off a previous review

[mbforbes]

Looks pretty good though I'm not familiar with this part of the code. Kicked travis and waiting on it.

[zmerlynn]

Isn't the aws Salt config still setting this unconditionally, or did I miss a different PR?

[justinsb]

@zmerlynn It is for kube-apiserver, but this is actually groundwork for kubelet. Kubelet must talk to AWS to mount EBS volumes. That work is in this PR #5138, which is getting really close...

Rather than add the aws.conf to kubelet (& minions), I made aws.conf optional.

I guess I could remove aws.conf everywhere now. This step-by-step approach feels a little safer though...

[justinsb]

Rebased (really just to force the tests to re-run)

[mbforbes]

This LGTM and tests pass, so I'll mark as so, but given @zmerlynn has more context than me, please feel free to disagree & hold this.

[zmerlynn]

Oh, sorry, LGTM, I just had that question.
On Apr 4, 2015 11:10 AM, "Maxwell Forbes" notifications@github.com wrote:

This LGTM and tests pass, so I'll mark as so, but given @zmerlynn
https://github.com/zmerlynn has more context than me, please feel free
to disagree & hold this.

—
Reply to this email directly or view it on GitHub
#6370 (comment)
.