Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the portal net used in the default ubuntu cluster scripts... #7136

Closed
wants to merge 1 commit into from

Conversation

a-robinson
Copy link
Contributor

...to actually be on a private IP range.

This came up in issue #6667.

@roberthbailey
Copy link
Contributor

LGTM.

@roberthbailey roberthbailey self-assigned this Apr 21, 2015
@roberthbailey roberthbailey added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 21, 2015
@thockin
Copy link
Member

thockin commented Apr 21, 2015

LGTM but I did not audit the rest of the ubuntu scripts to ensure that is unique... did you?

@a-robinson
Copy link
Contributor Author

Ugh, you're completely right, I don't actually know how flannel is allocating pod IPs in these setups, so I don't know whether they'll conflict. I should definitely learn how, but don't have the time today.

In the meantime, this shouldn't be merged.

@roberthbailey roberthbailey removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 21, 2015
@roberthbailey roberthbailey removed their assignment Apr 21, 2015
@WIZARD-CXY
Copy link
Contributor

@a-robinson The ip range that flannel used is configured by using `/opt/bin/etcdctl mk /coreos.com/network/config '{"Network":"10.0.0.0/16"}' by user
And our team is working on merge the ubuntu single node and multiple nodes into one as this pr
#5498.

@a-robinson
Copy link
Contributor Author

Ah, I wasn't aware of that work, @WIZARD-CXY. Thanks for the pointer! Is there any chance that, while you guys are in there, you or @resouer could swap out the 11.1.1.0/24 portal nets for a subnet in an actual private IP range, like something under 10.0.0.0/8 or 172.16.0.0/12?

@WIZARD-CXY
Copy link
Contributor

@a-robinson ok no problem

@a-robinson
Copy link
Contributor Author

Thanks!

@a-robinson a-robinson closed this Apr 22, 2015
@a-robinson a-robinson deleted the portal branch March 25, 2016 20:30
@a-robinson a-robinson restored the portal branch March 25, 2016 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants