Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Change kube2sky to use token-system-dns secret, point at https e... #7207

Merged
merged 1 commit into from Apr 23, 2015

Conversation

fabioy
Copy link
Contributor

@fabioy fabioy commented Apr 23, 2015

Reverts #7154. Seems to have caused the breaking of few e2e tests.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@fabioy
Copy link
Contributor Author

fabioy commented Apr 23, 2015

cc @roberthbailey

@cjcullen
Copy link
Member

LGTM. I'll dig into why...

@fabioy
Copy link
Contributor Author

fabioy commented Apr 23, 2015

Thanks. Will merge on green build.

fabioy added a commit that referenced this pull request Apr 23, 2015
Revert "Change kube2sky to use token-system-dns secret, point at https e...
@fabioy fabioy merged commit 162b0db into master Apr 23, 2015
@roberthbailey roberthbailey deleted the revert-7154-readonly branch May 9, 2015 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants