[WIP] - sidecar containers PoC #75099
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Joseph-Irving: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
do-not-merge/work-in-progress
|
Hi @Joseph-Irving. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
area/kubelet
kind/api-change
This was referenced Mar 7, 2019
k8s-ci-robot
removed
the
needs-rebase
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Joseph-Irving If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
luksa
reviewed
Apr 3, 2019
| //One of Standard, Sidecar. | ||
| //Defaults to Standard | ||
| //+optional | ||
| ContainerLifecycle ContainerLifecycle `json:"containerLifecycle,omitempty" protobuf:"bytes,22,opt,name=containerLifecycle,casttype=ContainerLifecycle"` |
There was a problem hiding this comment.
Having both lifecycle and containerLifecycle under pod.spec.containers might be confusing to users. Have you thought about introducing pod.spec.containers.lifecycle.type instead?
There was a problem hiding this comment.
yeah I did consider that, but I thought it might be confusing as the existing things in lifecycle are actions to perform whereas this isn't an action, it's a way of describing when your container should start up/shut down. There's a PR here kubernetes/enhancements#919 where the API implementation is being discussed
nyodas
pushed a commit
to DataDog/kubernetes
that referenced
this pull request
Jan 26, 2023
This change turns off the ability to completely kill pods when the non-sidecars are done. This is useful for cronjobs, where the non-sidecars finish work and exit, this code previously would clean up the pod and its resources. This feature was pulled in from kubernetes#75099. This is a feature that sounds nice in practice, but its not what we need. It seems to be a bit buggy since the Pod sandbox can potentially be deleted and recreated during the liftime of the Pod. That ain't good. Datadog: **NOT FROM UPSTREAM K8S**. From Lyft: lyft@a31b7fc datadog:patch
nyodas
pushed a commit
to DataDog/kubernetes
that referenced
this pull request
Jan 26, 2023
This change turns off the ability to completely kill pods when the non-sidecars are done. This is useful for cronjobs, where the non-sidecars finish work and exit, this code previously would clean up the pod and its resources. This feature was pulled in from kubernetes#75099. This is a feature that sounds nice in practice, but its not what we need. It seems to be a bit buggy since the Pod sandbox can potentially be deleted and recreated during the liftime of the Pod. That ain't good. Datadog: **NOT FROM UPSTREAM K8S**. From Lyft: lyft@a31b7fc datadog:patch
nyodas
pushed a commit
to DataDog/kubernetes
that referenced
this pull request
Jan 26, 2023
This change turns off the ability to completely kill pods when the non-sidecars are done. This is useful for cronjobs, where the non-sidecars finish work and exit, this code previously would clean up the pod and its resources. This feature was pulled in from kubernetes#75099. This is a feature that sounds nice in practice, but its not what we need. It seems to be a bit buggy since the Pod sandbox can potentially be deleted and recreated during the liftime of the Pod. That ain't good. Datadog: **NOT FROM UPSTREAM K8S**. From Lyft: lyft@a31b7fc datadog:patch
nyodas
pushed a commit
to DataDog/kubernetes
that referenced
this pull request
Jan 31, 2023
This change turns off the ability to completely kill pods when the non-sidecars are done. This is useful for cronjobs, where the non-sidecars finish work and exit, this code previously would clean up the pod and its resources. This feature was pulled in from kubernetes#75099. This is a feature that sounds nice in practice, but its not what we need. It seems to be a bit buggy since the Pod sandbox can potentially be deleted and recreated during the liftime of the Pod. That ain't good. Datadog: **NOT FROM UPSTREAM K8S**. From Lyft: lyft@a31b7fc datadog:patch
nyodas
pushed a commit
to DataDog/kubernetes
that referenced
this pull request
May 3, 2023
This change turns off the ability to completely kill pods when the non-sidecars are done. This is useful for cronjobs, where the non-sidecars finish work and exit, this code previously would clean up the pod and its resources. This feature was pulled in from kubernetes#75099. This is a feature that sounds nice in practice, but its not what we need. It seems to be a bit buggy since the Pod sandbox can potentially be deleted and recreated during the liftime of the Pod. That ain't good. Datadog: **NOT FROM UPSTREAM K8S**. From Lyft: lyft@a31b7fc datadog:patch
nyodas
pushed a commit
to DataDog/kubernetes
that referenced
this pull request
May 3, 2023
This change turns off the ability to completely kill pods when the non-sidecars are done. This is useful for cronjobs, where the non-sidecars finish work and exit, this code previously would clean up the pod and its resources. This feature was pulled in from kubernetes#75099. This is a feature that sounds nice in practice, but its not what we need. It seems to be a bit buggy since the Pod sandbox can potentially be deleted and recreated during the liftime of the Pod. That ain't good. Datadog: **NOT FROM UPSTREAM K8S**. From Lyft: lyft@a31b7fc datadog:patch
nyodas
pushed a commit
to DataDog/kubernetes
that referenced
this pull request
May 3, 2023
This change turns off the ability to completely kill pods when the non-sidecars are done. This is useful for cronjobs, where the non-sidecars finish work and exit, this code previously would clean up the pod and its resources. This feature was pulled in from kubernetes#75099. This is a feature that sounds nice in practice, but its not what we need. It seems to be a bit buggy since the Pod sandbox can potentially be deleted and recreated during the liftime of the Pod. That ain't good. Datadog: **NOT FROM UPSTREAM K8S**. From Lyft: lyft@a31b7fc datadog:patch
nyodas
pushed a commit
to DataDog/kubernetes
that referenced
this pull request
May 3, 2023
This change turns off the ability to completely kill pods when the non-sidecars are done. This is useful for cronjobs, where the non-sidecars finish work and exit, this code previously would clean up the pod and its resources. This feature was pulled in from kubernetes#75099. This is a feature that sounds nice in practice, but its not what we need. It seems to be a bit buggy since the Pod sandbox can potentially be deleted and recreated during the liftime of the Pod. That ain't good. Datadog: **NOT FROM UPSTREAM K8S**. From Lyft: lyft@a31b7fc datadog:patch
nyodas
pushed a commit
to DataDog/kubernetes
that referenced
this pull request
May 4, 2023
This change turns off the ability to completely kill pods when the non-sidecars are done. This is useful for cronjobs, where the non-sidecars finish work and exit, this code previously would clean up the pod and its resources. This feature was pulled in from kubernetes#75099. This is a feature that sounds nice in practice, but its not what we need. It seems to be a bit buggy since the Pod sandbox can potentially be deleted and recreated during the liftime of the Pod. That ain't good. Datadog: **NOT FROM UPSTREAM K8S**. From Lyft: lyft@a31b7fc datadog:patch
abhinavdahiya
pushed a commit
to lyft/kubernetes
that referenced
this pull request
Jun 15, 2023
This change turns off the ability to completely kill pods when the non-sidecars are done. This is useful for cronjobs, where the non-sidecars finish work and exit, this code previously would clean up the pod and its resources. This feature was pulled in from kubernetes#75099. This is a feature that sounds nice in practice, but its not what we need. It seems to be a bit buggy since the Pod sandbox can potentially be deleted and recreated during the liftime of the Pod. That ain't good.
abhinavdahiya
pushed a commit
to lyft/kubernetes
that referenced
this pull request
Jun 26, 2023
This change turns off the ability to completely kill pods when the non-sidecars are done. This is useful for cronjobs, where the non-sidecars finish work and exit, this code previously would clean up the pod and its resources. This feature was pulled in from kubernetes#75099. This is a feature that sounds nice in practice, but its not what we need. It seems to be a bit buggy since the Pod sandbox can potentially be deleted and recreated during the liftime of the Pod. That ain't good.
pl-jankowskimichal
pushed a commit
to DataDog/kubernetes
that referenced
this pull request
Jul 5, 2023
This change turns off the ability to completely kill pods when the non-sidecars are done. This is useful for cronjobs, where the non-sidecars finish work and exit, this code previously would clean up the pod and its resources. This feature was pulled in from kubernetes#75099. This is a feature that sounds nice in practice, but its not what we need. It seems to be a bit buggy since the Pod sandbox can potentially be deleted and recreated during the liftime of the Pod. That ain't good. Datadog: **NOT FROM UPSTREAM K8S**. From Lyft: lyft@a31b7fc datadog:patch
amardomingo
pushed a commit
to DataDog/kubernetes
that referenced
this pull request
Jul 10, 2023
This change turns off the ability to completely kill pods when the non-sidecars are done. This is useful for cronjobs, where the non-sidecars finish work and exit, this code previously would clean up the pod and its resources. This feature was pulled in from kubernetes#75099. This is a feature that sounds nice in practice, but its not what we need. It seems to be a bit buggy since the Pod sandbox can potentially be deleted and recreated during the liftime of the Pod. That ain't good. Datadog: **NOT FROM UPSTREAM K8S**. From Lyft: lyft@a31b7fc datadog:patch
abhinavdahiya
pushed a commit
to lyft/kubernetes
that referenced
this pull request
Jul 28, 2023
This change turns off the ability to completely kill pods when the non-sidecars are done. This is useful for cronjobs, where the non-sidecars finish work and exit, this code previously would clean up the pod and its resources. This feature was pulled in from kubernetes#75099. This is a feature that sounds nice in practice, but its not what we need. It seems to be a bit buggy since the Pod sandbox can potentially be deleted and recreated during the liftime of the Pod. That ain't good.
abhinavdahiya
pushed a commit
to lyft/kubernetes
that referenced
this pull request
Aug 10, 2023
This change turns off the ability to completely kill pods when the non-sidecars are done. This is useful for cronjobs, where the non-sidecars finish work and exit, this code previously would clean up the pod and its resources. This feature was pulled in from kubernetes#75099. This is a feature that sounds nice in practice, but its not what we need. It seems to be a bit buggy since the Pod sandbox can potentially be deleted and recreated during the liftime of the Pod. That ain't good.
twexler
pushed a commit
to DataDog/kubernetes
that referenced
this pull request
Sep 15, 2023
This change turns off the ability to completely kill pods when the non-sidecars are done. This is useful for cronjobs, where the non-sidecars finish work and exit, this code previously would clean up the pod and its resources. This feature was pulled in from kubernetes#75099. This is a feature that sounds nice in practice, but its not what we need. It seems to be a bit buggy since the Pod sandbox can potentially be deleted and recreated during the liftime of the Pod. That ain't good. Datadog: **NOT FROM UPSTREAM K8S**. From Lyft: lyft@a31b7fc datadog:patch
abhinavdahiya
pushed a commit
to lyft/kubernetes
that referenced
this pull request
Nov 29, 2023
This change turns off the ability to completely kill pods when the non-sidecars are done. This is useful for cronjobs, where the non-sidecars finish work and exit, this code previously would clean up the pod and its resources. This feature was pulled in from kubernetes#75099. This is a feature that sounds nice in practice, but its not what we need. It seems to be a bit buggy since the Pod sandbox can potentially be deleted and recreated during the liftime of the Pod. That ain't good.
nyodas
pushed a commit
to DataDog/kubernetes
that referenced
this pull request
Jan 8, 2024
This change turns off the ability to completely kill pods when the non-sidecars are done. This is useful for cronjobs, where the non-sidecars finish work and exit, this code previously would clean up the pod and its resources. This feature was pulled in from kubernetes#75099. This is a feature that sounds nice in practice, but its not what we need. It seems to be a bit buggy since the Pod sandbox can potentially be deleted and recreated during the liftime of the Pod. That ain't good. Datadog: **NOT FROM UPSTREAM K8S**. From Lyft: lyft@a31b7fc datadog:patch
nyodas
pushed a commit
to DataDog/kubernetes
that referenced
this pull request
Jan 8, 2024
This change turns off the ability to completely kill pods when the non-sidecars are done. This is useful for cronjobs, where the non-sidecars finish work and exit, this code previously would clean up the pod and its resources. This feature was pulled in from kubernetes#75099. This is a feature that sounds nice in practice, but its not what we need. It seems to be a bit buggy since the Pod sandbox can potentially be deleted and recreated during the liftime of the Pod. That ain't good. Datadog: **NOT FROM UPSTREAM K8S**. From Lyft: lyft@a31b7fc datadog:patch
nyodas
pushed a commit
to DataDog/kubernetes
that referenced
this pull request
Jan 8, 2024
This change turns off the ability to completely kill pods when the non-sidecars are done. This is useful for cronjobs, where the non-sidecars finish work and exit, this code previously would clean up the pod and its resources. This feature was pulled in from kubernetes#75099. This is a feature that sounds nice in practice, but its not what we need. It seems to be a bit buggy since the Pod sandbox can potentially be deleted and recreated during the liftime of the Pod. That ain't good. Datadog: **NOT FROM UPSTREAM K8S**. From Lyft: lyft@a31b7fc datadog:patch
nyodas
pushed a commit
to DataDog/kubernetes
that referenced
this pull request
Feb 23, 2024
This change turns off the ability to completely kill pods when the non-sidecars are done. This is useful for cronjobs, where the non-sidecars finish work and exit, this code previously would clean up the pod and its resources. This feature was pulled in from kubernetes#75099. This is a feature that sounds nice in practice, but its not what we need. It seems to be a bit buggy since the Pod sandbox can potentially be deleted and recreated during the liftime of the Pod. That ain't good. Datadog: **NOT FROM UPSTREAM K8S**. From Lyft: lyft@a31b7fc datadog:patch
nyodas
pushed a commit
to DataDog/kubernetes
that referenced
this pull request
Mar 18, 2024
This change turns off the ability to completely kill pods when the non-sidecars are done. This is useful for cronjobs, where the non-sidecars finish work and exit, this code previously would clean up the pod and its resources. This feature was pulled in from kubernetes#75099. This is a feature that sounds nice in practice, but its not what we need. It seems to be a bit buggy since the Pod sandbox can potentially be deleted and recreated during the liftime of the Pod. That ain't good. Datadog: **NOT FROM UPSTREAM K8S**. From Lyft: lyft@a31b7fc datadog:patch
nyodas
pushed a commit
to DataDog/kubernetes
that referenced
this pull request
Apr 11, 2024
This change turns off the ability to completely kill pods when the non-sidecars are done. This is useful for cronjobs, where the non-sidecars finish work and exit, this code previously would clean up the pod and its resources. This feature was pulled in from kubernetes#75099. This is a feature that sounds nice in practice, but its not what we need. It seems to be a bit buggy since the Pod sandbox can potentially be deleted and recreated during the liftime of the Pod. That ain't good. Datadog: **NOT FROM UPSTREAM K8S**. From Lyft: lyft@a31b7fc datadog:patch
nyodas
pushed a commit
to DataDog/kubernetes
that referenced
this pull request
Apr 11, 2024
This change turns off the ability to completely kill pods when the non-sidecars are done. This is useful for cronjobs, where the non-sidecars finish work and exit, this code previously would clean up the pod and its resources. This feature was pulled in from kubernetes#75099. This is a feature that sounds nice in practice, but its not what we need. It seems to be a bit buggy since the Pod sandbox can potentially be deleted and recreated during the liftime of the Pod. That ain't good. Datadog: **NOT FROM UPSTREAM K8S**. From Lyft: lyft@a31b7fc datadog:patch
nyodas
pushed a commit
to DataDog/kubernetes
that referenced
this pull request
Apr 22, 2024
This change turns off the ability to completely kill pods when the non-sidecars are done. This is useful for cronjobs, where the non-sidecars finish work and exit, this code previously would clean up the pod and its resources. This feature was pulled in from kubernetes#75099. This is a feature that sounds nice in practice, but its not what we need. It seems to be a bit buggy since the Pod sandbox can potentially be deleted and recreated during the liftime of the Pod. That ain't good. Datadog: **NOT FROM UPSTREAM K8S**. From Lyft: lyft@a31b7fc datadog:patch
nyodas
pushed a commit
to DataDog/kubernetes
that referenced
this pull request
Apr 22, 2024
This change turns off the ability to completely kill pods when the non-sidecars are done. This is useful for cronjobs, where the non-sidecars finish work and exit, this code previously would clean up the pod and its resources. This feature was pulled in from kubernetes#75099. This is a feature that sounds nice in practice, but its not what we need. It seems to be a bit buggy since the Pod sandbox can potentially be deleted and recreated during the liftime of the Pod. That ain't good. Datadog: **NOT FROM UPSTREAM K8S**. From Lyft: lyft@a31b7fc datadog:patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This is a PoC for the sidecars kep kubernetes/enhancements#753
None of this is final, it's just a first draft intended to show how and where the functionality could be implemented.
Currently this POC has:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: