Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e: external snapshotter #75133

Merged
merged 2 commits into from Mar 10, 2019
Merged

e2e: external snapshotter #75133

merged 2 commits into from Mar 10, 2019

Conversation

pohly
Copy link
Contributor

@pohly pohly commented Mar 7, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:

The recently introduced support for testing an external storage driver (PR #72836) had code for testing snapshotting, but that code turned out to be faulty:

  • drivers which supported snapshotting skipped a test that should have run
  • snapshotting failed because the snapshotter name was wrong

With this PR, the kubernetes-csi CI script runs the snapshotting test successfully.

Does this PR introduce a user-facing change?:

NONE

/sig storage
/assign @msau42
/priority important-soon

@pohly
e2e/storage: fix snapshot support in external driver testing
915d636 
When using an already installed driver, the snapshot name is the
original driver name. Renaming was incorrectly copied from the in-tree
CSI hostpath driver.
@pohly
e2e/storage: allow empty volume type
e84271e 
This can happen when the test pattern is about snapshotting.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. sig/storage Categorizes an issue or PR as relevant to SIG Storage. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 7, 2019
@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Mar 7, 2019
@msau42
Copy link
Member

msau42 commented Mar 7, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 7, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2019
@pohly
Copy link
Contributor Author

pohly commented Mar 7, 2019

/retest

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@pohly
Copy link
Contributor Author

pohly commented Mar 9, 2019

@kubernetes/kubernetes-milestone-maintainers : can you add the 1.14 milestone tag for this PR?

It's a fix for a test that is not used at the moment in Kubernetes itself, so changes to this code can't break anything.

@alejandrox1
Copy link
Contributor

Adding it to the v1.14 milestone since it is CI related
/milestone v1.14

@k8s-ci-robot k8s-ci-robot added this to the v1.14 milestone Mar 9, 2019
@k8s-ci-robot k8s-ci-robot merged commit 01c9edf into kubernetes:master Mar 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnufied gnufied Awaiting requested review from gnufied

@jeffvance jeffvance Awaiting requested review from jeffvance

Assignees

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.14
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pohly @msau42 @k8s-ci-robot @fejta-bot @alejandrox1