kubelet/rkt: Add KillPod() and GetPodStatus() for rkt.

[yifan-gu]

@vmarmol @dchen1107 @jonboulle @bakins

This adds KillPod() and GetPodStatus() .

Woo! Final PR to close #7244

We need another one or two for implementing the syncPod for rkt, so we can have it running!

⚡ ⚡ ⚡

[vmarmol]

LGTM

[yifan-gu]

Rebased, think the last three PRs will conflict with each other. But I will rebase (#7605 #7599 #7589)

[vmarmol]

LGTM

[vmarmol]

@yifan-gu and this one needs a rebase too

[yifan-gu]

Rebased. Think will need another one for this.

Git doesn't report conflict when both commits add the same thing. Awesome!

[vmarmol]

CI failure:

pkg/kubelet/rkt/rkt.go:551: r.GetPods undefined (type *Runtime has no field or method GetPods)

[yifan-gu]

I know, it depends that GetPods PR..

[vmarmol]

aaah, got it :)

[vmarmol]

@yifan-gu GetPods should be in

[yifan-gu]

@vmarmol Should be good now!

[vmarmol]

LGTM, will wait for the CI before merging. Looks like this is the last one for the day :) I have the SyncPod PR almost ready, will likely send out later tonight. Thanks for the heroic push @yifan-gu! The end is in sight.

[yifan-gu]

THANK YOU FOR FAST REVIEW AND MERGE!!!! @vmarmol !!
I will have the SyncPod for rkt tonight too!

Might need one or two more to make the interfaces same. And will need one for adding flags to enable rkt in kubelet!

🚀 🚀 🚀

[vmarmol]

In #7610 I do have the runningPod in SyncPod() I need to think a bit more if we need it or not. Safer if we have it...

[vmarmol]

IT IS GREEN! Merging.

[yifan-gu]

@vmarmol Yes, as I remember, the pods are splitted into pod by pod workers. We need to rethink about that. But it's safer and smoother to have runningPod for now :)

[pmorie]

Teamwork! 🏆

On Thu, Apr 30, 2015 at 9:53 PM, Yifan Gu notifications@github.com wrote:

@vmarmol https://github.com/vmarmol Yes, as I remember, the pods are
splitted into pod by pod workers. We need to rethink about that. But it's
safer and smoother to have runningPod for now :)

—
Reply to this email directly or view it on GitHub
#7605 (comment)
.