Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Enable import-boss for e2e framework dependency #81246

Closed
wants to merge 1 commit into from
Closed

WIP: Enable import-boss for e2e framework dependency #81246

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
34 changes: 34 additions & 0 deletions test/e2e/framework/.import-restrictions
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,40 @@
],
"ForbiddenPrefixes": []
},
{
"SelectorRegexp": "k8s[.]io/kubernetes/test/e2e/framework/",
"AllowedPrefixes": [],
"ForbiddenPrefixes": [
"k8s.io/kubernetes/test/e2e/framework/auth",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this? Wouldn't it by definition cause an import cycle?
All subpackages would import framework.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for my late response.

and you are right, all subpackages should be able to import the framework.
After understanding this verify-import-boss check way, I saw the above proposed change was invalid.
I will try to find the valid way to block circular import with this.

"k8s.io/kubernetes/test/e2e/framework/config",
"k8s.io/kubernetes/test/e2e/framework/deployment",
"k8s.io/kubernetes/test/e2e/framework/deviceplugin",
"k8s.io/kubernetes/test/e2e/framework/endpoints",
"k8s.io/kubernetes/test/e2e/framework/ginkgowrapper",
"k8s.io/kubernetes/test/e2e/framework/gpu",
"k8s.io/kubernetes/test/e2e/framework/ingress",
"k8s.io/kubernetes/test/e2e/framework/job",
"k8s.io/kubernetes/test/e2e/framework/kubelet",
"k8s.io/kubernetes/test/e2e/framework/lifecycle",
"k8s.io/kubernetes/test/e2e/framework/log",
"k8s.io/kubernetes/test/e2e/framework/metrics",
"k8s.io/kubernetes/test/e2e/framework/node",
"k8s.io/kubernetes/test/e2e/framework/perf",
"k8s.io/kubernetes/test/e2e/framework/pod",
"k8s.io/kubernetes/test/e2e/framework/podlogs",
"k8s.io/kubernetes/test/e2e/framework/providers",
"k8s.io/kubernetes/test/e2e/framework/psp",
"k8s.io/kubernetes/test/e2e/framework/replicaset",
"k8s.io/kubernetes/test/e2e/framework/resource",
"k8s.io/kubernetes/test/e2e/framework/service",
"k8s.io/kubernetes/test/e2e/framework/ssh",
"k8s.io/kubernetes/test/e2e/framework/statefulset",
"k8s.io/kubernetes/test/e2e/framework/testfiles",
"k8s.io/kubernetes/test/e2e/framework/timer",
"k8s.io/kubernetes/test/e2e/framework/viperconfig",
"k8s.io/kubernetes/test/e2e/framework/volume"
]
},
{
"SelectorRegexp": "k8s[.]io/kubernetes/third_party/",
"AllowedPrefixes": [
Expand Down