Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RecycableVolumePlugin interface #9020

Closed
wants to merge 2 commits into from
Closed

Add RecycableVolumePlugin interface #9020

wants to merge 2 commits into from

Conversation

markturansky
Copy link
Contributor

Adds interfaces for RecycableVolumePlugins. Implementations to follow.

I'm going to add to the fakeVolume and make unit tests. Ignore the 1st commit. It's cherry picked from the API PR and will be gone from this PR after that PR is merged.

3 of 5 PRs from #8334

@thockin

@k8s-bot
Copy link

k8s-bot commented May 30, 2015

EXPERIMENTAL JENKINS PR BUILDER: e2e build failed.

@erictune
Copy link
Member

erictune commented Jun 1, 2015

Thank you very much for the pull request - we sincerely appreciate the work that goes into sending us a change.

We are currently in a feature-freeze and general code slush as we work toward our 1.0 release. Our initial triage indicates that this is a non-critical change at this time, so we'd like to leave it open and revisit it after 1.0. We expect the freeze to wrap up in early to mid July.

If you feel that this triage is incorrect, please respond and let us know why. We're currently accepting changes that meet any of the following criteria:

Changes directly related to v1.0 issues: https://github.com/GoogleCloudPlatform/kubernetes/issues?q=is%3Aopen+is%3Aissue+milestone%3Av1.0
Changes addressing P0 bugs: https://github.com/GoogleCloudPlatform/kubernetes/issues?q=is%3Aopen+is%3Aissue+label%3Apriority%2FP0
Changes to supported platforms to bring them up to par with the primary development platforms
Docs, user experience, and test related fixes
Thanks again for your contribution! The community is really what has made this project so exciting.

@erictune erictune added this to the v1.0-post milestone Jun 1, 2015
@thockin
Copy link
Member

thockin commented Jun 2, 2015

LGTM modulo comments on the first layer, which is included herein. on-call do not merge until proper LGTM

@markturansky
Copy link
Contributor Author

Squashed and in-line with the API commit before it.

@k8s-bot
Copy link

k8s-bot commented Jun 2, 2015

EXPERIMENTAL JENKINS PR BUILDER: e2e build succeeded.

@markturansky markturansky mentioned this pull request Jun 2, 2015
Closed
9 tasks
@k8s-bot
Copy link

k8s-bot commented Jun 2, 2015

EXPERIMENTAL JENKINS PR BUILDER: e2e build succeeded.

@k8s-bot
Copy link

k8s-bot commented Jun 2, 2015

EXPERIMENTAL JENKINS PR BUILDER: e2e build succeeded.

@k8s-bot
Copy link

k8s-bot commented Jun 2, 2015

EXPERIMENTAL JENKINS PR BUILDER: e2e build succeeded.

@thockin
Copy link
Member

thockin commented Jun 2, 2015

LGTM then just one nit

@k8s-bot
Copy link

k8s-bot commented Jun 2, 2015

EXPERIMENTAL JENKINS PR BUILDER: e2e build succeeded.

@k8s-bot
Copy link

k8s-bot commented Jun 3, 2015

EXPERIMENTAL JENKINS PR BUILDER: e2e build succeeded.

@k8s-bot
Copy link

k8s-bot commented Jun 4, 2015

EXPERIMENTAL JENKINS PR BUILDER: e2e build succeeded.

@thockin
Copy link
Member

thockin commented Jun 5, 2015

LGTM cb547f4

@markturansky
Copy link
Contributor Author

Closing this PR. All commits accounted for in #9024.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thockin thockin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@markturansky @k8s-bot @erictune @thockin @googlebot