Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark --kubelet-https deprecated, unconditionally use https for apiserver->kubelet connections #91630

Merged
merged 1 commit into from Jun 2, 2020
Merged

Mark --kubelet-https deprecated, unconditionally use https for apiserver->kubelet connections #91630

merged 1 commit into from Jun 2, 2020

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Jun 1, 2020

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Kubelets have unconditionally used https to serve the endpoints the apiserver communicates with since before v1.0 (in #6380), and the apiserver flag to allow switching communication with the kubelet to http has not be usable since then.

This PR marks that flag as deprecated and removes the option for the kube-apiserver -> kubelet connection to switch from https to http.

Does this PR introduce a user-facing change?:

The kube-apiserver `--kubelet-https` flag is deprecated. kube-apiserver connections to kubelets now unconditionally use `https` (kubelets have unconditionally used `https` to serve the endpoints the apiserver communicates with since before v1.0).

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 1, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/apiserver area/kubelet approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 1, 2020
@liggitt liggitt mentioned this pull request Jun 1, 2020
Closed
@liggitt liggitt force-pushed the kube-apiserver-kubelet-https branch from ec0ee00 to a1cf6ae Compare June 1, 2020 14:48
@neolit123
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 1, 2020
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@liggitt liggitt force-pushed the kube-apiserver-kubelet-https branch from a1cf6ae to 2e8461a Compare June 2, 2020 00:54
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 2, 2020
@liggitt
Copy link
Member Author

liggitt commented Jun 2, 2020

fixed lint error

@liggitt liggitt added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 2, 2020
@liggitt
Copy link
Member Author

liggitt commented Jun 2, 2020

/priority backlog

@k8s-ci-robot k8s-ci-robot added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Jun 2, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jun 2, 2020
@neolit123
Copy link
Member

/lgtm

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@liggitt
Copy link
Member Author

liggitt commented Jun 2, 2020

/retest

1 similar comment
@liggitt
Copy link
Member Author

liggitt commented Jun 2, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit 7bd4c53 into kubernetes:master Jun 2, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jun 2, 2020
@liggitt liggitt deleted the kube-apiserver-kubelet-https branch June 2, 2020 15:02
@pacoxu pacoxu mentioned this pull request Apr 16, 2021
Merged
@githubixx githubixx mentioned this pull request Jan 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattjmcnaughton mattjmcnaughton Awaiting requested review from mattjmcnaughton

@nikhiljindal nikhiljindal Awaiting requested review from nikhiljindal

Assignees

@neolit123 neolit123

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@liggitt @k8s-ci-robot @neolit123 @fejta-bot