Graduate multiple sizes huge pages to GA #26664

bart0sh · 2021-02-22T10:28:12Z

This PR is a part of PR series to graduate support for multiple sizes hugepages to GA.

Support for multiple sizes huge pages was implemented in 1.18 and graduated to beta in 1.19.
Community feedback was positive since then, so it's time to graduate it to GA.

k8s PR: kubernetes/kubernetes#99144
KEP PR: kubernetes/enhancements#2534

netlify · 2021-02-22T10:39:26Z

Deploy preview for kubernetes-io-master-staging ready!

Built with commit f964dff

https://deploy-preview-26664--kubernetes-io-master-staging.netlify.app

tengqm · 2021-02-22T13:06:37Z

I believe this PR should go to the dev-1.21 branch rather than master.

k8sio-netlify-preview-bot · 2021-02-22T13:20:08Z

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

🔨 Explore the source changes: 7a0f9bc

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/60f54b4260414900079f736a

bart0sh · 2021-02-22T13:20:52Z

@tengqm thank you! rebased.

tengqm · 2021-02-22T13:49:00Z

/lgtm
Looks to me there is only one page where the feature gate is mentioned.

k8s-ci-robot · 2021-02-22T13:49:11Z

LGTM label has been added.

Git tree hash: 9540ce4be03956f48599572154272ca771423647

reylejano · 2021-02-22T15:55:44Z

/milestone 1.21

irvifa · 2021-02-25T21:38:51Z

/hold
Until kubernetes/kubernetes#99144 is merged

reylejano · 2021-03-11T05:29:52Z

Continue to hold after kubernetes/kubernetes#99144 is merged

Please see comment kubernetes/kubernetes#99144 (comment)

kubernetes/enhancements#1539 is currently not being tracked by the release team since it was not opted in before the enhancements freeze. Also with the code freeze deadline being yesterday, for this to be considered into the release, you'll need to request an exception. If you have any questions, please reach out on slack #sig-release. Thanks!

The related kubernetes/enhancements#2534 is not tracked for 1.21
See kubernetes/enhancements#2534 (comment)

ehashman

Needs rebase.

ehashman · 2021-05-14T17:50:28Z

content/en/docs/reference/command-line-tools-reference/feature-gates.md

@@ -124,7 +124,8 @@ different Kubernetes components.
 | `HPAContainerMetrics` | `false` | Alpha | 1.20 | |
 | `HPAScaleToZero` | `false` | Alpha | 1.16 | |
 | `HugePageStorageMediumSize` | `false` | Alpha | 1.18 | 1.18 |
-| `HugePageStorageMediumSize` | `true` | Beta | 1.19 | |
+| `HugePageStorageMediumSize` | `true` | Beta | 1.19 | 1.21 |
+| `HugePageStorageMediumSize` | `true` | GA | 1.22 | - |


This second line should be added to the graduated/deprecated table below.

I've added all 3 lines as it's done for HugePages feature.

These lines are for a GA'ed feature, so they are supposed to be MOVED to the second table, not just COPIED.

@tengqm Thank you for pointing it out. Done.

PI-Victor · 2021-05-14T21:30:59Z

/unassign
/milestone 1.22
/assign @ashnehete

PI-Victor · 2021-05-14T21:32:45Z

/sig node

sftim · 2021-07-04T12:53:07Z

@bart0sh how's this PR going? Does this feature need documentation changes for v1.22?

ehashman · 2021-07-07T19:02:42Z

PR still needs docs, waiting on final approvals for feature PR to merge.

@bart0sh can you please rebase?

bart0sh · 2021-07-15T13:10:04Z

@reylejano

/hold until the following:

PR targets the dev-1.22 branch

done

Enhancements Graduate multiple sizes huge pages to GA enhancements#2534 is tracked for 1.22

done

k/k PR promote huge page storage medium size to GA kubernetes#99144 has merged

done

Please unhold review and merge, thanks.

bart0sh · 2021-07-15T13:12:08Z

@sftim @ehashman sorry for the delay, I was on vacation.

@sftim Yes, these changed need to be merged into 1.22. Please review & merge.

Signed-off-by: Ed Bartosh <eduard.bartosh@intel.com>

tengqm · 2021-07-19T13:37:35Z

/lgtm
Leaving the approval and unhold to release team.

k8s-ci-robot · 2021-07-19T13:37:41Z

LGTM label has been added.

Git tree hash: e61dbe6f4ba00a5a6771069b93a95827938603a9

ehashman

/lgtm
for SIG Node

PI-Victor · 2021-07-21T13:56:50Z

thank you all for checking!

/hold cancel
/approve

k8s-ci-robot · 2021-07-21T13:57:07Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PI-Victor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~content/en/OWNERS~~ [PI-Victor]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language labels Feb 22, 2021

k8s-ci-robot requested review from celestehorgan and derekwaynecarr February 22, 2021 10:28

k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 22, 2021

bart0sh changed the base branch from master to dev-1.21 February 22, 2021 13:17

k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 22, 2021

bart0sh force-pushed the PR0004-multisize-hugepages-GA branch from 5ef8bd5 to 5115219 Compare February 22, 2021 13:20

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 22, 2021

k8s-ci-robot assigned tengqm Feb 22, 2021

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 22, 2021

k8s-ci-robot added this to the 1.21 milestone Feb 22, 2021

bart0sh mentioned this pull request Feb 22, 2021

promote huge page storage medium size to GA kubernetes/kubernetes#99144

Merged

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 25, 2021

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 9, 2021

bart0sh force-pushed the PR0004-multisize-hugepages-GA branch from 5115219 to 7ee87d9 Compare March 22, 2021 14:56

k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 22, 2021

bart0sh mentioned this pull request May 6, 2021

Graduate multiple sizes huge pages to GA kubernetes/enhancements#2534

Merged

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 12, 2021

ehashman suggested changes May 14, 2021

View reviewed changes

k8s-ci-robot unassigned PI-Victor May 14, 2021

k8s-ci-robot added this to the 1.22 milestone May 14, 2021

k8s-ci-robot assigned ashnehete May 14, 2021

k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label May 14, 2021

bart0sh force-pushed the PR0004-multisize-hugepages-GA branch from f1c6516 to e68a565 Compare July 15, 2021 13:07

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 15, 2021

bart0sh force-pushed the PR0004-multisize-hugepages-GA branch from e68a565 to 30f286f Compare July 15, 2021 13:18

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 15, 2021

Graduate multiple sizes huge pages to GA

7a0f9bc

Signed-off-by: Ed Bartosh <eduard.bartosh@intel.com>

bart0sh force-pushed the PR0004-multisize-hugepages-GA branch from 30f286f to 7a0f9bc Compare July 19, 2021 09:52

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 19, 2021

ehashman reviewed Jul 20, 2021

View reviewed changes

k8s-ci-robot assigned ehashman Jul 20, 2021

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 21, 2021

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2021

k8s-ci-robot merged commit 1a7b4a5 into kubernetes:dev-1.22 Jul 21, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Graduate multiple sizes huge pages to GA #26664

Graduate multiple sizes huge pages to GA #26664

bart0sh commented Feb 22, 2021

netlify bot commented Feb 22, 2021 •

edited

tengqm commented Feb 22, 2021

k8sio-netlify-preview-bot commented Feb 22, 2021 •

edited by netlify bot

bart0sh commented Feb 22, 2021

tengqm commented Feb 22, 2021

k8s-ci-robot commented Feb 22, 2021

reylejano commented Feb 22, 2021

irvifa commented Feb 25, 2021

reylejano commented Mar 11, 2021 •

edited

ehashman left a comment

ehashman May 14, 2021

bart0sh Jul 15, 2021

tengqm Jul 18, 2021

bart0sh Jul 19, 2021 •

edited

PI-Victor commented May 14, 2021

PI-Victor commented May 14, 2021

sftim commented Jul 4, 2021

ehashman commented Jul 7, 2021

bart0sh commented Jul 15, 2021

bart0sh commented Jul 15, 2021

tengqm commented Jul 19, 2021

k8s-ci-robot commented Jul 19, 2021

ehashman left a comment

PI-Victor commented Jul 21, 2021

k8s-ci-robot commented Jul 21, 2021

Graduate multiple sizes huge pages to GA #26664

Graduate multiple sizes huge pages to GA #26664

Conversation

bart0sh commented Feb 22, 2021

netlify bot commented Feb 22, 2021 • edited

tengqm commented Feb 22, 2021

k8sio-netlify-preview-bot commented Feb 22, 2021 • edited by netlify bot

bart0sh commented Feb 22, 2021

tengqm commented Feb 22, 2021

k8s-ci-robot commented Feb 22, 2021

reylejano commented Feb 22, 2021

irvifa commented Feb 25, 2021

reylejano commented Mar 11, 2021 • edited

ehashman left a comment

Choose a reason for hiding this comment

ehashman May 14, 2021

Choose a reason for hiding this comment

bart0sh Jul 15, 2021

Choose a reason for hiding this comment

tengqm Jul 18, 2021

Choose a reason for hiding this comment

bart0sh Jul 19, 2021 • edited

Choose a reason for hiding this comment

PI-Victor commented May 14, 2021

PI-Victor commented May 14, 2021

sftim commented Jul 4, 2021

ehashman commented Jul 7, 2021

bart0sh commented Jul 15, 2021

bart0sh commented Jul 15, 2021

tengqm commented Jul 19, 2021

k8s-ci-robot commented Jul 19, 2021

ehashman left a comment

Choose a reason for hiding this comment

PI-Victor commented Jul 21, 2021

k8s-ci-robot commented Jul 21, 2021

netlify bot commented Feb 22, 2021 •

edited

k8sio-netlify-preview-bot commented Feb 22, 2021 •

edited by netlify bot

reylejano commented Mar 11, 2021 •

edited

bart0sh Jul 19, 2021 •

edited