Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update seccomp docs for v1.27 #38987

Merged
merged 1 commit into from Feb 23, 2023
Merged

Update seccomp docs for v1.27 #38987

merged 1 commit into from Feb 23, 2023

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Jan 18, 2023 •
edited

seccomp annotation will become non-functional in v1.27, which will be now reflected in the documentation as well.

Ref: kubernetes/kubernetes#114947, kubernetes/enhancements#135, kubernetes/kubernetes#91286

cc @kubernetes/sig-node-pr-reviews @liggitt

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 18, 2023
@saschagrunert saschagrunert changed the base branch from main to dev-1.27 January 18, 2023 12:57
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 18, 2023
@saschagrunert saschagrunert changed the title Seccomp dev 1.27 Update seccomp docs for v1.27 Jan 18, 2023
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jan 18, 2023
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jan 18, 2023
@liggitt
Copy link
Member

liggitt commented Jan 18, 2023

/lgtm
for technical content

@netlify
Copy link

netlify bot commented Jan 18, 2023

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit c884c85
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/63c7eca313557d000b1acbe5
😎 Deploy Preview https://deploy-preview-38987--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 18, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6128458313108c63f1a166bfa11fa44d1e80773c

sftim
sftim reviewed Jan 18, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

I recommend rewording this further, though. We don't support any version of Kubernetes where these annotations aren't already deprecated.

content/en/docs/tutorials/security/seccomp.md Outdated Show resolved Hide resolved
content/en/docs/reference/labels-annotations-taints/_index.md Outdated Show resolved Hide resolved
content/en/docs/reference/labels-annotations-taints/_index.md Outdated Show resolved Hide resolved
content/en/docs/reference/labels-annotations-taints/_index.md Outdated Show resolved Hide resolved
@saschagrunert
Update seccomp docs for v1.27
c1bf88e 
seccomp annotation will become non-functional in v1.27, which will be
now reflected in the documentation as well.

Ref: kubernetes/kubernetes#114947

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 18, 2023
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 18, 2023
@saschagrunert
Copy link
Member Author

/lgtm

I recommend rewording this further, though. We don't support any version of Kubernetes where these annotations aren't already deprecated.

Thanks! Fixed as suggested.

sftim
sftim reviewed Jan 18, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

for docs

/hold

pending confirmation that this change is definitely part of the v1.27 release

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jan 18, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5f5a61c8e3f3cf6418ab3f1186ae659b5af40dc7

@pacoxu
Copy link
Member

pacoxu commented Jan 18, 2023

/lgtm

@bart0sh bart0sh moved this from Triage to Needs Approver in SIG Node PR Triage Jan 19, 2023
@saschagrunert
Copy link
Member Author

kubernetes/kubernetes#114947 merged into master and will be part of v1.27

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 24, 2023
@reylejano
Copy link
Member

/assign @mickeyboxell

@kbhawkey
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kbhawkey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 23, 2023
@k8s-ci-robot k8s-ci-robot merged commit aabfcc6 into kubernetes:dev-1.27 Feb 23, 2023
SIG Node PR Triage automation moved this from Needs Approver to Done Feb 23, 2023
@k8s-ci-robot k8s-ci-robot added this to the 1.27 milestone Feb 23, 2023
@saschagrunert saschagrunert deleted the seccomp-dev-1.27 branch February 23, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacoxu pacoxu pacoxu left review comments

@sftim sftim sftim left review comments

@Shubham82 Shubham82 Shubham82 left review comments

@pjbgf pjbgf Awaiting requested review from pjbgf

@tengqm tengqm Awaiting requested review from tengqm

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@liggitt liggitt

@pacoxu pacoxu

@mickeyboxell mickeyboxell

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
SIG Node PR Triage
Done
Milestone
1.27
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@saschagrunert @liggitt @k8s-ci-robot @pacoxu @reylejano @kbhawkey @sftim @Shubham82 @mickeyboxell