Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Typo in 714c119 using f-string (follow-up of follow-up of #1938) #1946

Merged

Conversation

rapsealk
Copy link
Member

@rapsealk rapsealk commented Mar 4, 2024

This PR is a follow-up to 714c119 to supply missing "f-string".

)
if server_version < MIN_API_VERSION:
warnings.warn(
"The server is too old ({server_version}) and does not meet the minimum API version"
f" requirement: v{MIN_API_VERSION[0]}.{MIN_API_VERSION[1]}\nPlease upgrade"
" the server or downgrade/reinstall the client SDK with the same"
" major.minor release of the server.",

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue
  • Installer updates including:
    • Fixtures for db schema changes
    • New mandatory config options
  • Update of end-to-end CLI integration tests in ai.backend.test
  • API server-client counterparts (e.g., manager API -> client SDK)
  • Test case(s) to:
    • Demonstrate the difference of before/after
    • Demonstrate the flow of abstract/conceptual models with a concrete implementation
  • Documentation
    • Contents in the docs directory
    • docstrings in public interfaces and type annotations

@rapsealk rapsealk added the type:bug Reports about that are not working label Mar 4, 2024
@rapsealk rapsealk added this to the 24.03 milestone Mar 4, 2024
@rapsealk rapsealk requested a review from achimnol March 4, 2024 02:19
@rapsealk rapsealk self-assigned this Mar 4, 2024
@github-actions github-actions bot added comp:client Related to Client component size:XS ~10 LoC labels Mar 4, 2024
@rapsealk rapsealk added the skip:changelog Make the action workflow to skip towncrier check label Mar 4, 2024
@rapsealk rapsealk changed the title fix: Typo in 714c1191c4634bcd2c9d21ba3fc764f40a5a1f36 using f-string fix: Typo in 714c119 using f-string Mar 4, 2024
Copy link
Member

@achimnol achimnol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@achimnol achimnol added this pull request to the merge queue Mar 4, 2024
@achimnol achimnol changed the title fix: Typo in 714c119 using f-string fix: Typo in 714c119 using f-string (follow-up of follow-up of #1938) Mar 4, 2024
Merged via the queue into main with commit 23dd822 Mar 4, 2024
38 of 56 checks passed
@achimnol achimnol deleted the fix/typo-f-string-714c1191c4634bcd2c9d21ba3fc764f40a5a1f36 branch March 4, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:client Related to Client component size:XS ~10 LoC skip:changelog Make the action workflow to skip towncrier check type:bug Reports about that are not working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants