Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: resize font-size of ads #1965

Merged
merged 2 commits into from Mar 26, 2024
Merged

docs: resize font-size of ads #1965

merged 2 commits into from Mar 26, 2024

Conversation

lizable
Copy link
Contributor

@lizable lizable commented Mar 26, 2024 •
edited by github-actions bot

This PR resolves cosmetic issue due to unexpected font-size in ethical ads by resizing into a small size with css customization.

After Before
Screenshot 2024-03-26 at 12 22 46鈥疨M Screenshot 2024-03-26 at 12 23 06鈥疨M

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue
  • Installer updates including:
    • Fixtures for db schema changes
    • New mandatory config options
  • Update of end-to-end CLI integration tests in ai.backend.test
  • API server-client counterparts (e.g., manager API -> client SDK)
  • Test case(s) to:
    • Demonstrate the difference of before/after
    • Demonstrate the flow of abstract/conceptual models with a concrete implementation
  • Documentation
    • Contents in the docs directory
    • docstrings in public interfaces and type annotations

馃摎 Documentation preview 馃摎: https://sorna--1965.org.readthedocs.build/en/1965/

馃摎 Documentation preview 馃摎: https://sorna-ko--1965.org.readthedocs.build/ko/1965/

@github-actions github-actions bot added the size:XS ~10 LoC label Mar 26, 2024
@lizable lizable marked this pull request as ready for review March 26, 2024 08:33
@lizable lizable requested a review from achimnol March 26, 2024 08:38
@lizable lizable added the area:docs Documentations label Mar 26, 2024
@achimnol achimnol added this pull request to the merge queue Mar 26, 2024
@achimnol achimnol added this to the 23.09 milestone Mar 26, 2024
Merged via the queue into main with commit 7470513 Mar 26, 2024
39 checks passed
@achimnol achimnol deleted the docs/resize-ads-font-size branch March 26, 2024 09:15
achimnol pushed a commit that referenced this pull request Mar 26, 2024
@lizable @achimnol
docs: resize font-size of ads (#1965)
b8f06a8 
Backported-from: main (24.03)
Backported-to: 23.09
@lizable lizable mentioned this pull request Mar 26, 2024
Merged
7 tasks
fregataa pushed a commit that referenced this pull request Mar 28, 2024
@lizable @fregataa
docs: resize font-size of ads (#1965)
2782828
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achimnol achimnol achimnol approved these changes

Assignees

@lizable lizable

Labels
area:docs Documentations size:XS ~10 LoC
Projects
None yet
Milestone
23.09
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lizable @achimnol