[5.8] Validate container alias registration #27390
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Container::getAlias() method currently throws LogicException. This exception is forwarded to many other container methods that call getAlias() and there are a lot of conflicts with the container interface.
Let's validate container alias registration to avoid these conflicts. And I think it's reasonable to add
@throws \LogicException
to \Illuminate\Contracts\Container\Container::alias(). Each class has to implement this logic.