[10.x] Adds inline attachments support for markdown mailables #47140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nunomaduro This solution is beautiful! I really just learned a lot by solving this myself and now look at your solution. Thanks and great work! |
nunomaduro
changed the title
$message variable on template
|
@dakira Could you please conduct some local tests to verify that this feature works as expected in your use case and does not break any existing behaviors? Thank you for helping! |
This was referenced Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes markdown access to
$messagevariable on template, by simply lazy render the markdown on the moment the$messagevariable as already available as view data.