Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.x] Fixes missing output on ProcessFailedException exception #47285

Merged
merged 2 commits into from May 30, 2023

Conversation

nunomaduro
Copy link
Member

This pull request adds the process's output to the ProcessFailedException's error message. Similar to what Symfony does to their own ProcessFailedException exception.

Note that, this pull request also changes the class extended by ProcessFailedException - as for sure, by mistake we were extending the RuntimeException of the console component.

Fixes: #47281.

@taylorotwell taylorotwell merged commit 9de048d into 10.x May 30, 2023
18 checks passed
@taylorotwell taylorotwell deleted the fix/failed-output-error-message branch May 30, 2023 14:17
@ManuelLeiner
Copy link

Works like a charm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Process facade / ProcessResult hides exceptions
4 participants