Off-by-one in timer setPeriod() function

Thanks CarlO!
leaflabs · Sep 3, 2010 · 1c6f9a9 · 1c6f9a9
1 parent 3b2cca3
commit 1c6f9a9
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/wirish/HardwareTimer.cpp b/wirish/HardwareTimer.cpp
@@ -77,8 +77,8 @@ uint16 HardwareTimer::setPeriod(uint32 microseconds) {
     // With a prescale factor of 1, there are 72counts/ms
     uint16 ps = ((microseconds*72)/65536) + 1;
     setPrescaleFactor(ps);
-    // Find this overflow will always be less than 65536
-    setOverflow((microseconds*72)/ps);
+    // Finally, this overflow will always be less than 65536
+    setOverflow(((microseconds*72)/ps) - 1);
     return this->overflow;    
 }
 void HardwareTimer::setChannel1Mode(uint8 mode) {