Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using the bottommost axes as the last axes instance #61

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

K20shores
Copy link

This allows issue #60 to to be resolved. I am unaware of the consequences of this, though.

@K20shores
Copy link
Author

K20shores commented Jul 22, 2021

This is the image generated with the same code in #60 using the patch I submitted in this PR, for your reference (with some added styling of the right hand figure).

image

@K20shores
Copy link
Author

Two of the tests in the python notebook fail:

  1. The first one that shows the grid. The bottom grid is drawn correctly, but the grids above that are drawn on top of the data. I am working on that
  2. The Unknown Pleasures album cover is not being displayed. I am not sure why. I will look into that after I figure out the grid.

If you happen to want to accept this as a PR and have any insight, please let me know.

@leotac
Copy link
Owner

leotac commented Jul 23, 2021

Hey! Thanks for the contribution. I'll take a look when I have the chance.

@K20shores
Copy link
Author

There are still some outlying problems:

  1. The Unknown Pleasures example, for some reason, is not rendering in the notebook for me.
  2. Grid lines in density estimate plots overlay the density estimate. That is not true for histograms.

I am looking into both.

@K20shores
Copy link
Author

Well, I figured out the Unknown Pleasures issue, all that's left is the grid zorder issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants