Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/v4.2.0 #3814

Merged
merged 12 commits into from Aug 19, 2023
Merged

Release/v4.2.0 #3814

merged 12 commits into from Aug 19, 2023

Conversation

matthew-dean
Copy link
Member

No description provided.

@matthew-dean
Copy link
Member Author

@iChenLei Crap, can you help figure out the reason for these failures? This should just include the PR for container queries, yet even though those tests were passing, these fail. I released 4.2.0, so it would be good to figure out what's wrong. I ran tests locally and they succeed, so what's different about CI?

@matthew-dean
Copy link
Member Author

@iChenLei I'm inclined to merge this, since this is what was released, but we definitely need to figure out the error reasons.

@matthew-dean
Copy link
Member Author

@iChenLei Another question -- how are you managing changelogs now? Manual updates?

package.json Outdated
@@ -27,7 +26,7 @@
},
"devDependencies": {
"github-changes": "^1.1.2",
"lerna": "^3.22.1",
"lerna": "^7.1.4",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's very likely due to the lerna upgrade.

@iChenLei
Copy link
Member

iChenLei commented Aug 6, 2023

@iChenLei Crap, can you help figure out the reason for these failures? This should just include the PR for container queries, yet even though those tests were passing, these fail. I released 4.2.0, so it would be good to figure out what's wrong. I ran tests locally and they succeed, so what's different about CI?

"lerna": "^7.1.4",

Sir, you upgrade the lerna from v3 to v7 (these major versions include some breaking changes, such as lerna bootstrap deprecated).

lerna v3 lerna v7

In lerna v3, the lerna cli install deps and Symlinking packages.

lerna notice cli v3.22.1
lerna info ci enabled
lerna info Bootstrapping 3 packages
lerna info Installing external dependencies
lerna info Symlinking packages and binaries
lerna success Bootstrapped 3 packages

but lerna v7 not, so we encounter follow issues:

Fatal error: Unable to find local grunt.

I fork your branch and add some changes:

"workspaces": ["packages/*"],

But it still has some issues: https://github.com/less/less.js/actions/runs/5774396195/job/15651297281#step:6:148


Append:

  1. node v16+ support npm's workspaces ( https://github.com/less/less.js/actions/runs/5774902148/job/15652317180#step:6:11
  2. ts-node and typescript issues (https://github.com/less/less.js/actions/runs/5774902148/job/15652317114#step:6:149

@iChenLei
Copy link
Member

iChenLei commented Aug 6, 2023

@iChenLei I'm inclined to merge this, since this is what was released, but we definitely need to figure out the error reasons.

options 1: downgrade lerna and releases v4.2.0
options 2: fix lerna upgrade issue

@iChenLei
Copy link
Member

iChenLei commented Aug 6, 2023

@iChenLei Another question -- how are you managing changelogs now? Manual updates?

Yes,Manual updates

@matthew-dean
Copy link
Member Author

@iChenLei ohhh ok, maybe it's resolving something locally which can't be resolved in CI, thanks for investigating.

@matthew-dean
Copy link
Member Author

@iChenLei The Windows test is permanently stuck, no matter how often it's run. It never runs the unit rest step. Can you investigate? Otherwise I've fixed the other tests. Also would you be able to update the change log?

@matthew-dean
Copy link
Member Author

Merging because all the other platforms work and no explicit errors are given. @iChenLei I'd be grateful if you could help figure out the Windows issue.

@matthew-dean matthew-dean merged commit 6390ae3 into less:master Aug 19, 2023
7 of 8 checks passed
@iChenLei iChenLei mentioned this pull request Aug 20, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants