Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WFE: Remove support for draft-ietf-acme-ari01 CertID format #7448

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

WFE: Remove support for draft-ietf-acme-ari01 CertID format #7448

wants to merge 3 commits into from
+44 −315

Conversation

beautifulentropy
Copy link
Member

Fixes #7183

@beautifulentropy beautifulentropy marked this pull request as ready for review April 23, 2024 20:40
@beautifulentropy beautifulentropy requested a review from a team as a code owner April 23, 2024 20:40
aarongable
aarongable requested changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@aarongable aarongable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for the wholesale removal of the integration test.

test/integration/ari_test.go Outdated Show resolved Hide resolved
aarongable
aarongable approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@aarongable aarongable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merged main to triple-check that the changes to the ari integration test were identical, and yep, that file disappeared entirely from this diff. LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarongable aarongable aarongable approved these changes

@pgporada pgporada Awaiting requested review from pgporada

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WFE: Remove support for draft-ietf-acme-ari01 CertID from RenewalInfo and UpdateRenewal methods
2 participants
@beautifulentropy @aarongable