Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow usage of script_file #6

Merged
merged 1 commit into from Jul 18, 2015
Merged

Allow usage of script_file #6

merged 1 commit into from Jul 18, 2015

Conversation

bra-fsn
Copy link
Contributor

@bra-fsn bra-fsn commented Jul 15, 2015

No description provided.

@lextoumbourou
Copy link
Owner

So passing script_file to the partial update API is an undocumented feature, I guess? Can't find any info about it in the docs, but can confirm it works (and looks like only in version >= 1.4.5 as per this issue).

I'm going to write a few more tests and update the docs for this method, but I'm happy with your commit.

Thanks again for your contribution.

✌️

lextoumbourou added a commit that referenced this pull request Jul 18, 2015
@lextoumbourou
Merge pull request #6 from bra-fsn/master
1bca725 
Allow usage of script_file
@lextoumbourou lextoumbourou merged commit 1bca725 into lextoumbourou:master Jul 18, 2015
@bra-fsn
Copy link
Contributor Author

bra-fsn commented Feb 25, 2016

@lextoumbourou: could you make a new release to pypi? I really miss this feature. :)

@lextoumbourou
Copy link
Owner

100 years later, we have a new version. Sorry @bra-fsn .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bra-fsn @lextoumbourou