[CVE-2022-43680] Fix overeager DTD destruction (fixes #649) #650
+62
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hartwork
changed the title
hartwork
force-pushed
the
issue-649-fix-overeager-dtd-destruction
branch
from
8b252a4
to
912af44
Compare
hartwork
changed the title
Closed
hartwork
force-pushed
the
issue-649-fix-overeager-dtd-destruction
branch
from
912af44
to
36f9ffb
Compare
|
Related: #616 (comment) |
|
Review time: A short and neat fix, I like it! I can't find any other places in the code where there might be a similar problem due to |
|
@RMJ10 excellent, thank you! |
hartwork
force-pushed
the
issue-649-fix-overeager-dtd-destruction
branch
2 times, most recently
from
dcb0deb
to
0648f8a
Compare
hartwork
changed the title
hartwork
changed the title
hartwork
force-pushed
the
issue-649-fix-overeager-dtd-destruction
branch
from
0648f8a
to
eedc5f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #649
Alternative patch + reproducer test case