Skip failure tests on riscv64. #877
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vapier
reviewed
Mar 12, 2024
| @@ -45,7 +45,7 @@ int main() | |||
|
|
|||
| // Rounding issue, won't fix as it only happens on mingw 32bit. | |||
| // __aarch64__/graviton. It fails within the CI while outside is 100% success over 100s builds&runs | |||
| #if defined(__MINGW32__) || defined(__aarch64__) || defined(_M_ARM64) | |||
| #if defined(__MINGW32__) || defined(__aarch64__) || defined(_M_ARM64) || defined(__riscv) | |||
There was a problem hiding this comment.
this covers riscv32 & riscv64, but the commit message only says riscv64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two tests don't fit riscv64 and therefore fail at build time, hopefully skipped.
This can prove that the modification is valid.