Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use overwrite_ip in Smokeping target generator when set #16012

Closed

Conversation

hvanderheide
Copy link
Contributor

In our environment we're unable to use DNS to resolve internal hostnames. We've been using overwrite_ip to get around this which is not considered by the Smokeping target generation script. This small small change adds a conditional to use the overwrite_ip device setting when set.

DO NOT DELETE THE UNDERLYING TEXT

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.
  • If my Pull Request makes discovery/polling/yaml changes, I have added/updated test data.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@murrant
Copy link
Member

murrant commented May 3, 2024

overwrite_ip is deprecated and discouraged, why are you using that and not just adding the device by IP and setting the display name?

@murrant murrant added the User-Pending Currently waiting for user response label May 8, 2024
@murrant murrant closed this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
User-Pending Currently waiting for user response
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants