Add support for setting the log callback with libusb_set_option/libusb_init_context #1265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjelmn
force-pushed
the
libusb_add_support_for_setting_callback_in_options
branch
2 times, most recently
from
eb496ea
to
777e008
Compare
|
There are CI build issues to be sorted out, for MSYS2 Clang and Appveyor (MSVC build). |
hjelmn
force-pushed
the
libusb_add_support_for_setting_callback_in_options
branch
from
777e008
to
3d8b856
Compare
|
Ok, that should fix it. Figured that most compilers had implemented the typeof extension but Microsoft did not bother with it. |
hjelmn
force-pushed
the
libusb_add_support_for_setting_callback_in_options
branch
from
3d8b856
to
f4618e1
Compare
|
Test under Windows are good, for both MinGW64 build MSVC x64 build. |
|
Alright. Looks good. Thanks @mcuee! Now to try to get one or two more reviews. |
Youw
reviewed
Apr 7, 2023
Youw
approved these changes
Apr 7, 2023
…b_init_context This commit effectively deprecates libusb_set_log_cb by adding support for setting the callback in either libusb_set_option or libusb_init_context. Since the libusb_set_log_cb is already in use we can not easily deprecate it without first incrementing the major version. We may do that in the future. Signed-off-by: Nathan Hjelm <hjelmn@google.com>
hjelmn
force-pushed
the
libusb_add_support_for_setting_callback_in_options
branch
from
f4618e1
to
d96a230
Compare
Youw
reviewed
Apr 11, 2023
|
Nothing else catching my sight. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit effectively deprecates libusb_set_log_cb by adding support for setting the callback in either libusb_set_option or libusb_init_context. Since the libusb_set_log_cb is already in use we can not easily deprecate it without first incrementing the major version. We may do that in the future.