Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make cltv_expiry_delta configurable and reduce the min/default some #849

Merged
merged 3 commits into from Mar 20, 2021
Merged

Make cltv_expiry_delta configurable and reduce the min/default some #849

merged 3 commits into from Mar 20, 2021

Commits on Mar 20, 2021

  1. Make cltv_expiry_delta configurable and reduce the min/default some 

    We allow users to configure the to_self_delay, which is analogous to
the cltv_expiry_delta in terms of its security context, so we should
allow users to specify both.

We similarly bound it on the lower end, but reduce that bound
somewhat now that it is configurable.
    @TheBlueMatt
    TheBlueMatt committed Mar 20, 2021
    Copy the full SHA
    c8d4536 View commit details
    Browse the repository at this point in the history

  2. Tweak our_to_self_delay documentation wording to make it flow better

    @TheBlueMatt
    TheBlueMatt committed Mar 20, 2021
    Copy the full SHA
    7503e2a View commit details
    Browse the repository at this point in the history

  3. Ignore patch codecov as long as total coverage is within 1% of base 

    In some PRs, codecov gets mad that the coverage of the patch itself
is lower than the base. In most cases, we largely don't want a Big
Red X, at least as long as the total coverage has not gone down
substantially.
    @TheBlueMatt
    TheBlueMatt committed Mar 20, 2021
    Copy the full SHA
    e640b93 View commit details
    Browse the repository at this point in the history