Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove un-used and broken TriangleSAHPred<T>& operator= method #83

Merged
merged 1 commit into from May 15, 2024

Conversation

Tyler799
Copy link
Contributor

This method was a problem previously, but GCC14 notices that it cannot work given that vertex_stride_bytes_ is const.

It's not used, so just remove it.

This method was a problem previously, but GCC14 notices that it cannot work given that vertex_stride_bytes_ is const.

It's not used, so just remove it.
@syoyo
Copy link
Contributor

syoyo commented May 10, 2024

operator= may be used in some user code. Adding 'mutable' to vertex_stride_bytes_ would be a recommend way for the fix.

@syoyo syoyo merged commit 03cf180 into lighttransport:release May 15, 2024
1 check passed
@syoyo
Copy link
Contributor

syoyo commented May 15, 2024

I am changing my mind.
copy-assignment operator for class having const variables are troublesome and probably no one actually uses copy-assignment operator of TriangleSAHPred class.

https://stackoverflow.com/questions/3658854/does-it-make-sense-to-implement-the-copy-assignment-operator-in-a-class-with-all

So merged PR. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants