Security fix - temp file created in unsecure way

linuxmint · Mar 17, 2010 · 3019939 · 3019939
1 parent 9355a4f
commit 3019939
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/usr/lib/linuxmint/mintUpdate/mintUpdate.py b/usr/lib/linuxmint/mintUpdate/mintUpdate.py
@@ -1402,15 +1402,17 @@ def setVisibleColumn(checkmenuitem, column, configName):
 
 # prepare the log
 pid = os.getpid()
-logdir = "/tmp/mintUpdate"
+logdir = "/tmp/mintUpdate/"
 if os.getuid() == 0 :
 
 	mode = "root"
 else:
 	mode = "user"
 os.system("mkdir -p " + logdir)
-logFile = logdir + "/" + parentPid + "_" + str(pid) + ".log"
-log = open(logFile, "w")
+#logFile = logdir + "/" + parentPid + "_" + str(pid) + ".log"
+#log = open(logFile, "w")
+log = tempfile.NamedTemporaryFile(prefix = logdir, delete=False)
+logFile = log.name
 
 log.writelines("++ Launching mintUpdate in " + mode + " mode\n")
 log.flush()