Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error messaging for missing columns in .dtf files #113

Merged
merged 3 commits into from
Sep 28, 2023
Merged

Better error messaging for missing columns in .dtf files #113

merged 3 commits into from
Sep 28, 2023

Conversation

ccrook
Copy link
Contributor

@ccrook ccrook commented Sep 28, 2023

Two main changes relating CSV format definition files:

  • if a format definition file does not include a required_columns command then every referenced column is considered required unless a default value is also specified where it is referenced.
  • a new optional_columns command has been added to just specifying optional columns - all others without a default clause are considered required

@ccrook
fix: error message for missing columns and optional_columns dtf command
8ddd522 
Note: regressions tests testgx1, testgx2, testgx3 changed due to
different station having maximum change in last iteration, floating
point difference?
@ccrook
chore: update workflow checkout version
f67aec9
@ccrook
doc: Updating documentation on format defintion files
3e9ed3e
@ccrook ccrook merged commit 92aeef9 into master Sep 28, 2023
4 checks passed
@ccrook ccrook deleted the fix--missing-col-errors branch September 28, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ccrook