Fix compilation errors when using tasking compiler(cctc) #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geky
requested changes
Dec 8, 2020
| }, | ||
| }; | ||
| int __attrcount__=sizeof(__lfs_mattr__)/sizeof(struct lfs_mattr); | ||
| err = lfs_dir_commit(lfs, dir, __lfs_mattr__,__attrcount__); |
There was a problem hiding this comment.
Sorry, this change adds too much noise and defeats the API of the internal lfs_dir_commit function. Is there an alternative?
There was a problem hiding this comment.
no .the tasking compiler is a professional compiler in the field of automotive electronics. This compiler does not support high C language standard(such as : c14)
There was a problem hiding this comment.
What warning does cctc output for this line? LFS_MKATTRS just passes a point to a stack allocated array of static size, which shouldn't be too strange.
littlefs is should be strictly c99, otherwise useful features such as inline, arbitrary variable declarations, uint32_t, wouldn't be available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix compilation errors when using tasking compiler