Adding language support for Hebrew #1740
Conversation
maehne
changed the title
There was a problem hiding this comment.
Thanks @YovelB for your localization effort! As I am not familiar with Hebrew, I can only look at the formal aspects. Please fix the minor things that I noticed. It seems that you intent to translate also the documentation. If you should notice typos/errors/inconsistencies in the English original documentation, it would be great if you could fix them to and ideally submit them in a separate PR (just to limit the already considerable size of this one).
Please add also a comment about the added localization to CHANGES.md and yourself as contributor to credits.md.
src/main/resources/resources/logisim/strings/util/util_he.properties
Outdated
Show resolved
Hide resolved
src/main/resources/resources/logisim/strings/proj/proj_he.properties
Outdated
Show resolved
Hide resolved
src/main/resources/resources/logisim/strings/hdl/hdl_he.properties
Outdated
Show resolved
Hide resolved
|
@mbaillif: Do you have any remarks on this PR? |
|
I'm done translating the documentation in Few Issues:
Thanks for responding, feel free to edit or ask questions. Note: About the documentation of the English version I will see what I can do about it. |
There was a problem hiding this comment.
Thanks for all the work! Looks mostly good to me except for some minor details (e.g. missing spaces) and merge conflicts requiring resolution. Note that some parts of the documentation are known to be outdated. If you should notice any particular cases, it would be great if you could file issues for them or even suggest corrections to the English version.
| canModifyError=לא ניתן לשנות מעגל. | ||
| changeComponentAttributesAction=שנה תכונות רכיב | ||
| exclusiveError=רכיב מתנגש כבר שם. | ||
| moveWorkingMsg=חיבורי מחשוב... |
There was a problem hiding this comment.
Please use systematically horizontal ellipsis (U+2026) "…" instead of three dots.
| buzzerFrequecy=תדר | ||
| buzzerVolume=נפח | ||
| buzzerVolumeBitWidth=רוחב סיביות נפח | ||
| buzzerUnitDhz=dHz (0.1Hz) |
There was a problem hiding this comment.
Add non-breaking space between value and unit.
| להנדסה ואדריכלות של ז'נבה</a>,<a href="https://heig-vd.ch/" rel="nofollow">בית ספר תיכון | ||
| להנדסה וניהול של קנטון ווד</a>) החלו לפתח גרסה של Logisim שמתאימה להם | ||
| קורסים, המשלבים מספר כלים -- למשל כרונוגרמה, אפשרות לבדוק את הסכמות ישירות | ||
| על לוח אלקטרוני, קונסולות TCL/TK, ... |
There was a problem hiding this comment.
Please use systematically horizontal ellipsis (U+2026) "…" instead of three dots.
| </li> | ||
| <li>שינוי קוד | ||
| </li> | ||
| <li>... |
There was a problem hiding this comment.
Please use systematically horizontal ellipsis (U+2026) "…" instead of three dots.
| </li> | ||
| <li>מעגלי בדיקה | ||
| </li> | ||
| <li>... אם אתה מוכן לתרום עם כל אחד מאלה, אל תהסס לפנות אלינו! |
There was a problem hiding this comment.
Please use systematically horizontal ellipsis (U+2026) "…" instead of three dots.
| </p> | ||
| <blockquote> | ||
| - <a href="fet-creating.html">יצירת חבילות</a><br> | ||
| - כיצד להפיץ אותם מחדש על גבי חוטים או כלים אחרים.<a href="fet-splitting.html">מפצלים</a><br> |
| תוויות עם מספר עצמי | ||
| </h1> | ||
| <p> | ||
| אפשרות זו מאפשרת לך למקם רכיבים עם תוויות ממוספרות עצמית למשל Led_1, Led_2... . להשתמש בזה, |
There was a problem hiding this comment.
Use horizontal ellipsis "…" instead of three dots.
| אתה יכול לערוך את הערכים הנוכחיים המופיעים בעמודות הפלט על ידי לחיצה על הערך המעניין. אתה יכול | ||
| שנה את הערכים הנוכחיים בעמודות הפלט על ידי לחיצה על הערך שבו אתה מעוניין ושימוש ב- | ||
| מקשי המקלדת <b class="tkeybd">0,1</b> ו-<b class="tkeybd">-</b> (המייצגים ערך לא מוגדר) או ב- | ||
| למעלה הכפתורים <b class="button">-</b> , <b class="button">1</b> , <b class="button">0</b> . לאחר הכניסה ל |
There was a problem hiding this comment.
Remove spaces after comma and dots?
| דף זה מתאר את שתי הכרטיסיות הראשונות, <b class="button">כניסות ויציאות</b> ו<b class="button">טבלה</b>. | ||
| העמוד הבא של המדריך מתאר את שתי הכרטיסיות האחרונות, ביטוי וממוזער. |
There was a problem hiding this comment.
Looks inconsistent: once space after the comma and once before...
| בית ספר מיוחד ברנז'ה</a>,<a href="https://hepia.hesge.ch/" rel="nofollow">בית ספר תיכון לנוף, | ||
| להנדסה ואדריכלות של ז'נבה</a>,<a href="https://heig-vd.ch/" rel="nofollow">בית ספר תיכון |
|
@YovelB: It would be nice if you could address the merge conflict and points raised in my review, so that this PR can be merged before the next release, which will probably happen around the beginning of the autumn term (mid September). |
|
Congratulations on this great translation task. I took the liberty of taking the translation from your git and including it in my inventory of documentation on this git : if you don't want it, let me know. On this repository I'm checking and trying to match the documentation to version 3.9, which is progressing slowly. You'll also find the jsearch-indexer.jar utility for building the contents of the search_lookup.he folder in the "xressourcesfordoc" folder. |
|
@maehne I'm sorry I've been busy with work and college. I won't be able to make it to the next release. I have different priorities now. I hope you can understand. |
@YovelB: Of course, we understand! @mbaillif: Could you maybe give us a hand to resolve the conflicts and merge this considerable localisation effort in the near future. It seems to be already in a very helpful state and once it is integrated maybe other users might contribute further corrections and improvements. |
There are still some problems with some files with IntelliJ analysis giving tons of warnings.
In the search_lookup_he folder in the schema file, what value should I give id1?
And locale.he is detected in the app yet does not change anything. Am I missing something?
Note: use UTF-8 for default file encoding for properties and files (To see the Hebrew language instead of question marks).