Add support for VHDL time units #1937
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sparr
requested review from
BFH-ktt1,
davidhutchens,
maehne,
MarcinOrlowski and
zdimension
as code owners
sparr
commented
Jan 3, 2024
| @@ -287,7 +288,7 @@ private boolean parsePorts(Scanner input) throws IllegalVhdlContentException { | |||
| if (!input.next(OPENLIST)) throw new IllegalVhdlContentException(S.get("portDeclarationException")); | |||
| parsePort(input); | |||
| while (input.next(SEMICOLON)) parsePort(input); | |||
| if (!input.next(DONELIST)) throw new IllegalVhdlContentException(S.get("portDeclarationException")); | |||
| if (!input.next(DONELIST)) throw new IllegalVhdlContentException(S.get("portDeclarationException") + " before " + input.remaining()); | |||
There was a problem hiding this comment.
This additional error output was very helpful in identifying the problem.
|
@sparr : What I am missing, or maybe not understanding correctly, is following: I do not find a possibility to enable or disable the time-units. Hence, how I understand your PR, in VHDL the time-units will always be inserted. If this is the case, it will break a lot in logisim, as synthesis tools will "choke" on the time-units. Please add an option to enable or disable the time-units, with the default to disabled. |
|
This PR affects loading/parsing of files, not saving/writing. |
|
@sparr : Could you please fix the linter errors, such that I can merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://redirect.cs.umbc.edu/portal/help/VHDL/types.html
https://www.aldec.com/en/support/resources/documentation/articles/1165
This is only a partial fix. A more correct solution would be to create a new non-generic type for
timewhich keeps track of units separately from the value. However, this was the best I could do quickly, and it does succeed at loading the vhdl files I was working with at the time which all use relatively small units.