-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add componentDidUpdate to update when the icon changes #45
base: develop
Are you sure you want to change the base?
Conversation
@jackpilowsky what's the reason for 4653fdf ? |
Hello guys, can somebody merge this request? |
Nice catch. @jackpilowsky can you remove the dist folder so I can merge? |
@yojona dist folder removed |
.gitignore
Outdated
@@ -6,4 +6,3 @@ | |||
.idea | |||
npm-debug.log | |||
node_modules | |||
dist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add this line again? and let's restore the package-lock.
I think we are good only with the changes on src/index.js
Thanks!
Fixes #44