This repository has been archived by the owner on Dec 7, 2020. It is now read-only.
Use ID token on refresh if access token is not a JWT #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yogu
commented
Aug 7, 2020
|
|
||
| rawIDToken, ok := tkn.Extra("id_token").(string) | ||
| if !ok { | ||
| return jose.JWT{}, "", time.Time{}, time.Duration(0), errors.New("unable to obtain id token") |
There was a problem hiding this comment.
I guess we don't need to fail here if we still can parse the access token
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use ID token on refresh if access token is not a JWT
Summary
Currently, the refresh flow assumes that the access token is a JWT and if it isn't, the refresh fails. The initial token fetch routine already copes with this case by parsing the id token first, and only then tries to parse the access token. I copied the same logic into the token refresh routine.
Type
[x] Bug fix
[] Feature request
[] Enhancement
[] Docs
Why?
As far as I understand the OpenID Connect spec, you are not really supposed to parse the access token, and e.g. in the case of GitLab, it's not a JWT.
Requirements
Having an OIDC provider that sends access tokens that are not JWTs
How to try it?
Set up a GitLab application and use it, then see if the refresh flow works.
Additional informatoin
I don't really know either Go nor OpenID Connect, so please carefully review this and tell me if it makes sense.
Checklist: