Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-44246: Add functionality to use an external footprint set for NoiseReplacer in SingleFrameMeasurementTask. #275

Merged
merged 1 commit into from
May 8, 2024
Merged

DM-44246: Add functionality to use an external footprint set for NoiseReplacer in SingleFrameMeasurementTask. #275

merged 1 commit into from
May 8, 2024

Conversation

erykoff
Copy link
Contributor

@erykoff erykoff commented May 8, 2024

No description provided.

fred3m
fred3m reviewed May 8, 2024
View reviewed changes
Copy link
Contributor

@fred3m fred3m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of small comments. Mostly, I'm thinking that it would be useful to make getFootprintsFromCatalog a method of a SourceCatalog, since it would be useful to other users. In fact, I thought that it already was.

python/lsst/meas/base/baseMeasurement.py Show resolved Hide resolved
tests/test_NoiseReplacer.py Show resolved Hide resolved
@erykoff erykoff merged commit 197f127 into main May 8, 2024
2 checks passed
@erykoff erykoff deleted the tickets/DM-44246 branch May 8, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fred3m fred3m fred3m left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@erykoff @fred3m