Add ensure_tvariantequals
#116
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agladysh
reviewed
Nov 10, 2022
agladysh
reviewed
Nov 10, 2022
agladysh
reviewed
Nov 10, 2022
lua-nucleo/ensure.lua
Outdated
| -- } | ||
| -- ) | ||
| -- | ||
| -- -- will throw the error: |
There was a problem hiding this comment.
похоже на то, копипаста, исправил по всех местах отдельным коммитом
agladysh
reviewed
Nov 10, 2022
agladysh
reviewed
Nov 10, 2022
agladysh
reviewed
Nov 10, 2022
agladysh
reviewed
Nov 10, 2022
| @@ -49,6 +51,13 @@ local ordered_pairs | |||
| 'ordered_pairs' | |||
| } | |||
|
|
|||
| local newproxy = newproxy or select( | |||
There was a problem hiding this comment.
Это какой-то стандартный способ подключения newproxy, который используется везде. Насколько могу вспонить, это утверждённый способ подключения newproxy в lua-nucleo, чтобы не было жёсткой зависимости.
There was a problem hiding this comment.
а зачем оно раскопировано везде, а не в модуле сидит?
E-Fir
force-pushed
the
avr/9644/add-ensure_tvariantequals
branch
from
7948ab2
to
195c05c
Compare
E-Fir
force-pushed
the
avr/9644/add-ensure_tvariantequals
branch
from
195c05c
to
3a2f767
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.