-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various tests fixes #75
base: master
Are you sure you want to change the base?
Conversation
…t, add BROKEN_IF condition
…als-lua5_1}: tests are BROKEN_IF cannot load lua-aplicado shell module
[run] test/cases/0230-tserialize-metatables.lua Suite `metatables test' failed: * Test `2': Metatable not ignored (i) * Test `3': Metatable not ignored (i)
LUA51 = _VERSION == 'Lua 5.1' | ||
LUA52 = _VERSION == 'Lua 5.2' | ||
LUA53 = _VERSION == 'Lua 5.3' | ||
LUA54 = _VERSION == 'Lua 5.4' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ой
что это и зачем? :(((
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
это глобальные переменные времени выполнения тестов, чтобы было удобно писать например test:BROKEN_IF(LUA52 or LUA53):....
введение именно таких глобальных переменных выглядит для меня самым удачным решением для целей, которые я обозначил
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
использование глобальных переменных недопустимо
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
эту правку я уже видел в #74. что происходит?
No description provided.