feat(pxp): add zephyr support #6159
Conversation
|
Hi, We can merge it now as a hotfix, however I think a proper solution would be to
What do you think? |
Add semaphore and connect IRQ. Originally proposed by @0xFarahFl.
|
Hey @kisvegabor
With that one I am still a bit hesitant - the OSAL needs dynamic thread creation and this is still marked as experimental so subject to change. By keeping the OSAL intree for now we can make sure that any changes will cause CI breakage and are addresed. https://github.com/zephyrproject-rtos/zephyr/blob/74ddfbc8a2e4f1932bf2b6a160f83a27a6c135a5/kernel/Kconfig#L237
Good point I'll adjust this PR accordingly :^) |
Changes the PXP osal to use the thread_sync to signal PXP readyness from the ISR.
There was a problem hiding this comment.
Thank you! It's good for me, but I hope @nicusorcitu and/or @anaGrad can take a look too.
|
@cristian-stoica should review it also |
| #endif | ||
| #if defined(__ZEPHYR__) | ||
| static K_SEM_DEFINE(s_pxpIdleSem, 0, 1); | ||
| #if LV_USE_OS |
There was a problem hiding this comment.
PXP can work with or without FreeRTOS support.
PXP in baremetal mode means that SDK_OS_FREE_RTOS = 0.
While LV_USE_OS is a feature added in LVGL v9 for drawing parallelism. Those two defines have a different meaning.
I will give you an example:
SDK_OS_FREE_RTOS = 1
LV_USE_OS = LV_OS_NONE
This means that we will use LVGL single thread mode (same as LVGL v8) but PXP will have FreeRTOS support.
There was a problem hiding this comment.
Understood, so this destinction needs to be handled.
There was a problem hiding this comment.
We can fix later this behavior. If you fix-up the inclusions then you can merge this PR as is.
FASTSHIFT
changed the title
|
Sorry, it might not be directly related to this PR but my question concerns the lvgl_support.h in this PR . In order to test the zephyr support, I had to comment it and add LCD_WIDTH and LCD_HEIGHT macros but I want to know what was the intended content of this file and where to find it? |
|
LCD_WIDTH and LCD_HEIGHT were used in LVGL v8 just to define a temporary buffer needed by PXP for processing complex operations into multiple steps. That buffer has been removed in LVGl v9 so the defines are no longer needed in LVGL v9. |
|
Can you provide me with the link please? |
https://github.com/nxp-mcuxpresso/lvgl is the repository for NXP LVGL releases. |
|
Hi @FASTSHIFT |
This reverts commit e1cc12e.
Ah my bad, I revert it #6261 |
|
No worries, we could fix it later. |
| @@ -25,6 +25,11 @@ | |||
| #include "semphr.h" | |||
| #endif | |||
|
|
|||
| #if defined(__ZEPHYR__) | |||
There was a problem hiding this comment.
Please remove the above inclusions:
#if defined(SDK_OS_FREE_RTOS)
#include "FreeRTOS.h"
#include "semphr.h"
#endif
and replace it with:
#include "../../../osal/lv_os.h"
There was a problem hiding this comment.
Applied your suggestion.
There was a problem hiding this comment.
Just need the include and then the PR can be merged.
There was a problem hiding this comment.
I suppose that since the PR was merged once GitHub does not display new changes. I guess a new PR is needed
Add semaphore and connect IRQ.
Originally proposed by @0xFarahFl. zephyrproject-rtos/lvgl#52
Description of the feature or fix
A clear and concise description of what the bug or new feature is.
Notes
lv_conf_template.hrun lv_conf_internal_gen.py and update Kconfig.scripts/code-format.py(astyle version v3.4.12 needs to be installed) and follow the Code Conventions.