incus/storage_volume: Add yaml support for create #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stgraber
reviewed
May 10, 2024
cmd/incus/storage_volume.go
Outdated
Comment on lines
636
to
645
| vol := api.StorageVolumesPost{ | ||
| Name: volName, | ||
| Type: volType, | ||
| ContentType: c.flagContentType, | ||
| StorageVolumePut: volumePut, | ||
| } |
There was a problem hiding this comment.
This causes build failures as you are no longer initializing Config to an empty map.
|
Needs a tiny fix and a rebase. |
awalvie
force-pushed
the
yaml-support-storage-volume-create
branch
from
da0aef4
to
ea313c1
Compare
|
Pushed the fixes! |
|
I don't know why it closed, sorry about that. |
awalvie
force-pushed
the
yaml-support-storage-volume-create
branch
from
ea313c1
to
44daf7e
Compare
Part of lxc#741 Signed-off-by: Vishesh Agrawal <agrawal.vishesh.178@gmail.com>
Signed-off-by: Vishesh Agrawal <agrawal.vishesh.178@gmail.com>
awalvie
force-pushed
the
yaml-support-storage-volume-create
branch
from
44daf7e
to
356b229
Compare
|
Couple of stupid mistakes, sorry about the force pushes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #741