Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure no leading or trailing whitespace on the string input #206

Merged

Conversation

Pianist038801
Copy link
Contributor

Signed-off-by: Pianist038801 steven@union.ai

This adds validation on the input to ensure no leading/trailing whitespace.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Tracking Issue

fixes flyteorg/flyte#909

Follow-up issue

NA

Signed-off-by: Pianist038801 <steven@union.ai>
@codecov
Copy link

codecov bot commented Sep 20, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@a890e72). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #206   +/-   ##
=========================================
  Coverage          ?   64.13%           
=========================================
  Files             ?      358           
  Lines             ?     7639           
  Branches          ?     1323           
=========================================
  Hits              ?     4899           
  Misses            ?     2740           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a890e72...e6a4135. Read the comment docs.

Copy link
Contributor

@csirius csirius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jsonporter jsonporter merged commit a9a1e9b into master Sep 20, 2021
@flyte-bot
Copy link
Collaborator

🎉 This PR is included in version 0.25.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@anrusina anrusina deleted the fix/ensure-no-leading-trailing-whitespace-on-the-input branch January 13, 2022 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants