Windows compatibility #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hemselves should be written in UTF-8 as well
File::Spec returns paths that are native to the operating system and is not meant to build urls in html. This means that on most unixy systems everything goes well, since it generates / separators. However on Windows it generates backslashes, which do not work in HTML. Similar issues will crop up on older mac systems (uses :) or VMS (i don't even know what exactly this does). File::Spec is simply the wrong tool to use and should be replaced with something that translates any local path to an uri representation, but i don't want to upset the internals too much for now. As such i've resorted to swapping backslashes with forward slashes on Windows wherever appropiate.
|
Thank you. I've merged them and uploaded it to CPAN as 0.39 |
|
Awesome, thanks a ton for being so quick about it! :D |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heya, thanks again for making this repo.
In this branch you'll find changes to make sure that non-ascii characters actually get translated to UTF when printing the files and more importantly:
Changes that ensure that HTML paths don't contain backslashes on windows. Please also see the commit message there for more details. :)