Update the list of supported phoneme ASR alignment languages. #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supported languages and the corresponding models can be seen here: https://github.com/m-bain/whisperX/blob/main/whisperx/alignment.py#L24-L54
|
@m-bain This is an uncontroversial README improvement suggestion but the language list update is now a little out of date (from Oct 2023) if one looks at the relevant section of code linked to above.. PR #757 is probably a better approach and if incorporated would render this PR worth closing un-actioned. It might be encouraging of contributions to merge this and then immediately merge #757 (or else just reject this here and leave a thank you note for the original contributor?). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The list of supported phoneme ASR alignment models can be found here: https://github.com/m-bain/whisperX/blob/main/whisperx/alignment.py#L24-L54