DRY up Backend::Base#start.

Fix weird spec failure caused by magic matcher: has_error => be_error
macournoyer · Aug 1, 2008 · 528a99a · 528a99a · tmm1 · Aug 1, 2008
1 parent d2ac3ad
commit 528a99a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/lib/thin/backends/base.rb b/lib/thin/backends/base.rb
@@ -45,16 +45,16 @@ def initialize
       # Start the backend and connect it.
       def start
         @stopping = false
-        # Allow for early run up of eventmachine. TODO : maybe move this into
-        # a method or proc to DRY.
-        if EventMachine.reactor_running?
+        starter   = proc do
           connect
           @running = true
+        end
+
+        # Allow for early run up of eventmachine.
+        if EventMachine.reactor_running?
+          starter.call
         else
-          EventMachine.run do
-            connect
-            @running = true
-          end
+          EventMachine.run(&starter)
         end
       end
 

diff --git a/spec/request/parser_spec.rb b/spec/request/parser_spec.rb
@@ -169,7 +169,7 @@
 
       sorta_safe.size.should == nread
       parser.should be_finished
-      parser.should_not have_error
+      parser.should_not be_error
     end
   end