add documentation for assignCustomerToGuestCart mutation #9252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m2-github-services
added
Partner: Atwix
partners-contribution
andrewbess
approved these changes
Nov 17, 2021
There was a problem hiding this comment.
Hello @karyna-tsymbal-atwix
Thank you for your contribution.
It looks good from technical side.
m2-community-project
bot
moved this from Ready for Review
to Reviewer Approved
in Pull Request Progress
m2-community-project
bot
added
Progress: approved
and removed
Progress: ready for review
labels
keharper
reviewed
Nov 19, 2021
src/guides/v2.4/graphql/mutations/assign-customer-to-guest-cart.md
Outdated
Show resolved
Hide resolved
m2-community-project
bot
moved this from Reviewer Approved
to Review in Progress
in Pull Request Progress
keharper
added
2.4.4
Community
keharper
requested changes
Dec 2, 2021
|
|
||
| The `assignCustomerToGuestCart` mutation assigns a logged in customer and merge customer's shopping cart items to the specified guest shopping cart. | ||
|
|
||
| The customer must be logged in (You must specify the customer’s authorization token in the headers). |
There was a problem hiding this comment.
Replace this line with the standard "This mutation requires a valid customer authentication token." and move it to the bottom of this section.
| Customer now is assigned to that active cart. | ||
|
|
||
| *Note:* | ||
| Customer cart becomes inactive and the guest cart remains active; but for guest cart new `masked_id` is being generated. |
There was a problem hiding this comment.
Why are masked_id and quote_id mentioned here, when neither are part of the request or response?
There was a problem hiding this comment.
Hi @keharper , I mentioned them because I think it's a useful information for the developers, who can be confused why there is no old masked_id in the database, but a new one appeared instead.
I can remove this note if you think that it's unnecessary information.
There was a problem hiding this comment.
Suggested change
| Customer cart becomes inactive and the guest cart remains active; but for guest cart new `masked_id` is being generated. | |
| The `masked_id` of the guest cart contains a new value. The `quote_id` remains the same. |
src/guides/v2.4/graphql/mutations/assign-customer-to-guest-cart.md
Outdated
Show resolved
Hide resolved
src/guides/v2.4/graphql/mutations/assign-customer-to-guest-cart.md
Outdated
Show resolved
Hide resolved
src/guides/v2.4/graphql/mutations/assign-customer-to-guest-cart.md
Outdated
Show resolved
Hide resolved
src/guides/v2.4/graphql/mutations/assign-customer-to-guest-cart.md
Outdated
Show resolved
Hide resolved
m2-community-project
bot
moved this from Review in Progress
to Changes Requested
in Pull Request Progress
m2-community-project
bot
added
Progress: changes requested
and removed
Progress: review
labels
m2-community-project
bot
moved this from Changes Requested
to Review in Progress
in Pull Request Progress
m2-community-project
bot
added
Progress: review
and removed
Progress: changes requested
labels
karyna-tsymbal-atwix
force-pushed
the
docs-for-assignCustomerToGuestCart-graphql-mutation
branch
from
3e09345
to
2db4e9d
Compare
karyna-tsymbal-atwix
force-pushed
the
docs-for-assignCustomerToGuestCart-graphql-mutation
branch
from
2db4e9d
to
d247290
Compare
keharper
requested changes
Jan 4, 2022
src/guides/v2.4/graphql/mutations/assign-customer-to-guest-cart.md
Outdated
Show resolved
Hide resolved
| Customer now is assigned to that active cart. | ||
|
|
||
| *Note:* | ||
| Customer cart becomes inactive and the guest cart remains active; but for guest cart new `masked_id` is being generated. |
There was a problem hiding this comment.
Suggested change
| Customer cart becomes inactive and the guest cart remains active; but for guest cart new `masked_id` is being generated. | |
| The `masked_id` of the guest cart contains a new value. The `quote_id` remains the same. |
src/guides/v2.4/graphql/mutations/assign-customer-to-guest-cart.md
Outdated
Show resolved
Hide resolved
m2-community-project
bot
moved this from Review in Progress
to Changes Requested
in Pull Request Progress
m2-community-project
bot
added
Progress: changes requested
and removed
Progress: review
labels
m2-community-project
bot
moved this from Changes Requested
to Review in Progress
in Pull Request Progress
m2-community-project
bot
added
Progress: review
and removed
Progress: changes requested
labels
keharper
approved these changes
Jan 5, 2022
Pull Request Progress
automation
moved this from Review in Progress
to Reviewer Approved
Jan 5, 2022
|
@magento import code to magento-devdocs/devdocs |
|
@keharper the branch with the code is successfully imported into the |
m2-community-project
bot
moved this from Reviewer Approved
to Done
in Pull Request Progress
8 tasks
hguthrie
removed
the
Waiting for Response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This pull request (PR) adds a documentation page for the
assignCustomerToGuestCartmutation (GraphQL).Magento 2 GitHub Issue: magento/magento2#32615
Magento 2 GitHub PR: magento/magento2#33106
Fixes #9248
Affected DevDocs pages
Links to Magento source code
whatsnew
Added the
assignCustomerToGuestCartmutation.