Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent @hey.com addresses from being suggested to be in error #180

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

dhh
Copy link

@dhh dhh commented Jul 3, 2020

Right now mailcheck will suggest that someone entering "david@hey.com" really meant "david@sky.com".

Right now mailcheck will suggest that someone entering "david@hey.com" really meant "david@sky.com".
@kelly-tock
Copy link

looks like this is approved, is this module maintained anymore?

Copy link

@kelly-tock kelly-tock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@adisamicheal
Copy link

Can we please have this PR merged since it is an urgent concern. The domain @hey.com is widely used now.

@ferreiro
Copy link

Hey @dhh @kelly-tock @adisamicheal, this library is no longer maintained, and it sucks...

I rewrote it entirely, added HEY and many more domains, and update it for 2022 and onward: https://github.com/ZooTools/email-spell-checker

Let me know your thoughts! :)

  • 💙 Written in TypeScript and removed jQuery
  • ✅ Fixed a couple of bugs like this or this
  • 🚀 Reduced bundle size to <2KB.

  • ✨ Update TLDs (69+) and added modern startup domains (like .io, .so, .xyz or .dev)
  • 🙏 Implemented suggestions that people made in this repo that were ignored.

Link: https://github.com/ZooTools/email-spell-checker

Come check it out and give it a ⭐️ for the effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants