Merge pull request cms-sw#306 from degano/fix_L2_commenter

Do not skip commenter for cycle if L2 is not among the singing category
makortel · Jan 28, 2015 · b85b441 · b85b441
2 parents fcd0420 + 36b2bfb
commit b85b441
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/process-pull-request b/process-pull-request
@@ -194,10 +194,8 @@ if __name__ == "__main__":
       if re.match("merge", first_line):
         mustMerge = True
 
-    # Check L2 signoff
-    if commenter in CMSSW_L2:
-      if not [x for x in CMSSW_L2[commenter] if x in signing_categories]:
-        continue
+    # Check L2 signoff for users in this PR signing categories
+    if commenter in CMSSW_L2 and [x for x in CMSSW_L2[commenter] if x in signing_categories]:
       if re.match("^([+]1|approve[d]?|sign|signed)$", first_line):
         for sign in CMSSW_L2[commenter]:
           signatures[sign] = "approved"