Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

seibu/t5182.cpp: Remove hardcoded tags, Cleanups: #12425

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

cam900
Copy link
Contributor

@cam900 cam900 commented Jun 1, 2024

  • Use DERIVED_CLOCK for Z80 clock input
  • Fix spacing
  • Correct typename for variables
  • Use C++ style comments for single line comments

seibu/darkmist.cpp: Cleanups

  • Reduce literal tag usage and runtime tag lookups
  • Reduce unnecessary lines
  • Fix spacings

seibu/metlfrzr.cpp: Cleanups

  • Reduce literal tag usage and runtime tag lookups
  • Constantize variables
  • Fix spacing
  • Fix ROM region namings
  • Use C++ style comments for single line comments
  • Fix filename in comment

seibu/mustache.cpp: Cleanups

  • Fix spacing
  • Fix main CPU ROM region size

seibu/panicr.cpp: Cleanups

  • Fix typo in comment
  • Reduce preprocessor defines
  • Reduce literal tag usages and runtime tag lookups
  • Use mark_tile_dirty for text tilemap layer mark dirty method
  • Fix screen draw routine with cliprect
  • Constantize variables
  • Fix spacing
  • Reduce unnecessary lines
  • Suppress side effects for debugger read
  • Fix ROM region namings
  • Use C++ style comments for single line comments
  • Fix main CPU ROM region size

- Use DERIVED_CLOCK for Z80 clock input
- Fix spacing
- Correct typename for variables
- Use C++ style comments for single line comments

seibu/darkmist.cpp: Cleanups
- Reduce literal tag usage and runtime tag lookups
- Reduce unnecessary lines
- Fix spacings

seibu/metlfrzr.cpp: Cleanups
- Reduce literal tag usage and runtime tag lookups
- Constantize variables
- Fix spacing
- Fix ROM region namings
- Use C++ style comments for single line comments
- Fix filename in comment

seibu/mustache.cpp: Cleanups
- Fix spacing
- Fix main CPU ROM region size

seibu/panicr.cpp: Cleanups
- Fix typo in comment
- Reduce preprocessor defines
- Reduce literal tag usages and runtime tag lookups
- Use mark_tile_dirty for text tilemap layer mark dirty method
- Fix screen draw routine with cliprect
- Constantize variables
- Fix spacing
- Reduce unnecessary lines
- Suppress side effects for debugger read
- Fix ROM region namings
- Use C++ style comments for single line comments
- Fix main CPU ROM region size
@galibert galibert merged commit 02078b1 into mamedev:master Jun 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants