Skip to content

Commit

Permalink
[10410] Fix wrong sql
Browse files Browse the repository at this point in the history
  • Loading branch information
@Laise
virusav authored and Laise committed Aug 27, 2010
1 parent 2a2a7f1 commit 36249a0
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 6 deletions.
5 changes: 1 addition & 4 deletions sql/mangos.sql
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ CREATE TABLE `db_version` (
`version` varchar(120) default NULL,
`creature_ai_version` varchar(120) default NULL,
`cache_id` int(10) default '0',
`required_10409_02_mangos_spell_proc_event` bit(1) default NULL
`required_10410_01_mangos_spell_chain` bit(1) default NULL
) ENGINE=MyISAM DEFAULT CHARSET=utf8 ROW_FORMAT=FIXED COMMENT='Used DB version notes';

--
Expand Down Expand Up @@ -16297,9 +16297,6 @@ INSERT INTO spell_chain VALUES
(28610,11740,6229,4,0),
(47890,28610,6229,5,0),
(47891,47890,6229,6,0),
/*Fel Synergy*/
(47230,0,47230,1,0),
(47231,47230,47230,2,0),
/*------------------
--(355)Affliction
------------------*/
Expand Down
3 changes: 3 additions & 0 deletions sql/updates/10410_01_mangos_spell_chain.sql
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
ALTER TABLE db_version CHANGE COLUMN required_10409_02_mangos_spell_proc_event required_10410_01_mangos_spell_chain bit;

DELETE FROM spell_chain WHERE spell_id IN (47230, 47231);
2 changes: 2 additions & 0 deletions sql/updates/Makefile.am
View file
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ pkgdata_DATA = \
10400_01_mangos_mangos_string.sql \
10409_01_mangos_spell_chain.sql \
10409_02_mangos_spell_proc_event.sql \
10410_01_mangos_spell_chain.sql \
README

## Additional files to include when running 'make dist'
Expand Down Expand Up @@ -152,4 +153,5 @@ EXTRA_DIST = \
10400_01_mangos_mangos_string.sql \
10409_01_mangos_spell_chain.sql \
10409_02_mangos_spell_proc_event.sql \
10410_01_mangos_spell_chain.sql \
README
2 changes: 1 addition & 1 deletion src/shared/revision_nr.h
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#ifndef __REVISION_NR_H__
#define __REVISION_NR_H__
#define REVISION_NR "10409"
#define REVISION_NR "10410"
#endif // __REVISION_NR_H__
2 changes: 1 addition & 1 deletion src/shared/revision_sql.h
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#ifndef __REVISION_SQL_H__
#define __REVISION_SQL_H__
#define REVISION_DB_CHARACTERS "required_10332_02_characters_pet_aura"
#define REVISION_DB_MANGOS "required_10409_02_mangos_spell_proc_event"
#define REVISION_DB_MANGOS "required_10410_01_mangos_spell_chain"
#define REVISION_DB_REALMD "required_10008_01_realmd_realmd_db_version"
#endif // __REVISION_SQL_H__

3 comments on commit 36249a0

@virusav
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where query:
INSERT INTO spell_proc_event VALUES (47230, 0x7F, 5, 0x00000000, 0x00000000, 0x00000000, 0x00000000, 0x00000000, 0x00000000, 0x00000000, 0x00000000, 0x00000000, 0x00000000, 0x00000000, 0.000000, 0.000000, 0);
?

@Wowka321
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Laise, look please into Aura::CanProcFrom. Somethink wrong here, or maybe in Unit::ProcDamageAndSpellFor.
Some healers trinkets like
http://www.wowhead.com/spell=71611
can't proc from heal, cuz CanProcFrom return false here
if (spell->SpellFamilyName != GetSpellProto()->SpellFamilyName)
return false;
or just false in the end if spelfamily same.
Thx)

@Laise
Copy link
Contributor

@Laise Laise commented on 36249a0 Aug 28, 2010

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, should be fixed in [10416]

Please sign in to comment.