Skip to content

Commit

Permalink
[9555] Makes some arguments as references in some ByteBuffer operator…
Browse files Browse the repository at this point in the history
… methods.

Signed-off-by: ApoC <apoc@nymfe.net>
  • Loading branch information
apoc committed Mar 8, 2010
1 parent 11822c7 commit 418e31b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions src/shared/ByteBuffer.h
Original file line number Diff line number Diff line change
Expand Up @@ -506,7 +506,7 @@ class ByteBuffer
};

template <typename T>
inline ByteBuffer &operator<<(ByteBuffer &b, std::vector<T> v)
inline ByteBuffer &operator<<(ByteBuffer &b, std::vector<T> const& v)
{
b << (uint32)v.size();
for (typename std::vector<T>::iterator i = v.begin(); i != v.end(); ++i)
Expand All @@ -532,7 +532,7 @@ inline ByteBuffer &operator>>(ByteBuffer &b, std::vector<T> &v)
}

template <typename T>
inline ByteBuffer &operator<<(ByteBuffer &b, std::list<T> v)
inline ByteBuffer &operator<<(ByteBuffer &b, std::list<T> const& v)
{
b << (uint32)v.size();
for (typename std::list<T>::iterator i = v.begin(); i != v.end(); ++i)
Expand Down
2 changes: 1 addition & 1 deletion src/shared/revision_nr.h
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#ifndef __REVISION_NR_H__
#define __REVISION_NR_H__
#define REVISION_NR "9554"
#define REVISION_NR "9555"
#endif // __REVISION_NR_H__

3 comments on commit 418e31b

@Pilop
Copy link

@Pilop Pilop commented on 418e31b Mar 8, 2010

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

g++ -DHAVE_CONFIG_H -I. -I../../../src/game -I../.. -I../../../dep/ACE_wrappers -I../../dep/ACE_wrappers -I/usr/local/include/mysql -I/usr/include -I../../src/shared -I../../../src/game -I../../../src/game/../../dep/include -I../../../src/game/../framework -I../../../src/game/../shared -I../../../src/game/../shared/vmap -I../../../src/game/../realmd -DSYSCONFDIR="/opt/compile/bin9552/etc/" -DDO_MYSQL -g -O2 -MT SpellAuras.o -MD -MP -MF .deps/SpellAuras.Tpo -c -o SpellAuras.o ../../../src/game/SpellAuras.cpp
../../../src/game/../shared/ByteBuffer.h: In member function 'void Aura::SendFakeAuraUpdate(uint32, bool)':
../../../src/game/../shared/ByteBuffer.h:497: error: 'void ByteBuffer::append(T) [with T = PackedGuid]' is private
../../../src/game/SpellAuras.cpp:1247: error: within this context
gmake[3]: *** [SpellAuras.o] Error 1
gmake[3]: Leaving directory /opt/compile/9552/objdir/src/game' gmake[2]: *** [all-recursive] Error 1 gmake[2]: Leaving directory/opt/compile/9552/objdir/src'
gmake[1]: *** [all-recursive] Error 1
gmake[1]: Leaving directory `/opt/compile/9552/objdir'
gmake: *** [all] Error 2

@Pilop
Copy link

@Pilop Pilop commented on 418e31b Mar 8, 2010

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compile problem
g++ -DHAVE_CONFIG_H -I. -I../../../src/game -I../.. -I../../../dep/ACE_wrappers -I../../dep/ACE_wrappers -I/usr/local/include/mysql -I/usr/include -I../../src/shared -I../../../src/game -I../../../src/game/../../dep/include -I../../../src/game/../framework -I../../../src/game/../shared -I../../../src/game/../shared/vmap -I../../../src/game/../realmd -DSYSCONFDIR="/opt/compile/bin9552/etc/" -DDO_MYSQL -g -O2 -MT SpellAuras.o -MD -MP -MF .deps/SpellAuras.Tpo -c -o SpellAuras.o ../../../src/game/SpellAuras.cpp
../../../src/game/../shared/ByteBuffer.h: In member function 'void Aura::SendFakeAuraUpdate(uint32, bool)':
../../../src/game/../shared/ByteBuffer.h:497: error: 'void ByteBuffer::append(T) [with T = PackedGuid]' is private
../../../src/game/SpellAuras.cpp:1247: error: within this context
gmake[3]: *** [SpellAuras.o] Error 1
gmake[3]: Leaving directory /opt/compile/9552/objdir/src/game' gmake[2]: *** [all-recursive] Error 1 gmake[2]: Leaving directory/opt/compile/9552/objdir/src'
gmake[1]: *** [all-recursive] Error 1
gmake[1]: Leaving directory `/opt/compile/9552/objdir'
gmake: *** [all] Error 2

@Elyotna
Copy link

@Elyotna Elyotna commented on 418e31b Mar 9, 2010

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your crash looks related to either 9550 or 9551..!

Please sign in to comment.